Skip to content

8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

krk
Copy link
Contributor

@krk krk commented Oct 16, 2024

Remove unused _claim_token field from ShenandoahSATBAndRemarkThreadsClosure.


Progress

  • JDK-8311656 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1055/head:pull/1055
$ git checkout pull/1055

Update a local copy of the PR:
$ git checkout pull/1055
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1055

View PR using the GUI difftool:
$ git pr show -t 1055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1055.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

👋 Welcome back krk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@krk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 9308dec: 8328402: Implement pausing functionality for the PassFailJFrame
  • 42b3607: 8342669: [21u] Fix TestArrayAllocatorMallocLimit after backport of JDK-8315097
  • 8a35e8f: 8341997: Tests create files in src tree instead of scratch dir
  • b010fdc: 8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option
  • c62b0a5: 8325610: CTW: Add StressIncrementalInlining to stress options
  • a2f0ddb: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
  • 5013360: 8341806: Gcc version detection failure on Alinux3
  • 3fc07f2: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
  • 27d2abe: 8320892: AArch64: Restore FPU control state after JNI
  • fe4b0fa: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
  • ... and 20 more: https://git.openjdk.org/jdk21u-dev/compare/9e582fcbb8ab34b44ff01ac13de5cc4d6487396d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 0b0e064e36082200ace384c92eae02d3f7baa7ba 8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

⚠️ @krk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2024

Webrevs

@krk
Copy link
Contributor Author

krk commented Oct 16, 2024

/approval request Delete unused field, leftover from removal of claim_token in Shenandoah. No functional changes or regressions are expected, as this field is not referenced anywhere in the current implementation.

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@krk
8311656: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 16, 2024
@krk
Copy link
Contributor Author

krk commented Oct 22, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@krk
Your change (at version 46108b1) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

Going to push as commit da87df7.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 9308dec: 8328402: Implement pausing functionality for the PassFailJFrame
  • 42b3607: 8342669: [21u] Fix TestArrayAllocatorMallocLimit after backport of JDK-8315097
  • 8a35e8f: 8341997: Tests create files in src tree instead of scratch dir
  • b010fdc: 8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option
  • c62b0a5: 8325610: CTW: Add StressIncrementalInlining to stress options
  • a2f0ddb: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
  • 5013360: 8341806: Gcc version detection failure on Alinux3
  • 3fc07f2: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
  • 27d2abe: 8320892: AArch64: Restore FPU control state after JNI
  • fe4b0fa: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
  • ... and 20 more: https://git.openjdk.org/jdk21u-dev/compare/9e582fcbb8ab34b44ff01ac13de5cc4d6487396d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 22, 2024
@openjdk openjdk bot closed this Oct 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@shipilev @krk Pushed as commit da87df7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants