Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319879: Stress mode to randomize incremental inlining decision #106

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 30, 2023

I backport this for parity with 21.0.3-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319879 needs maintainer approval

Issue

  • JDK-8319879: Stress mode to randomize incremental inlining decision (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/106/head:pull/106
$ git checkout pull/106

Update a local copy of the PR:
$ git checkout pull/106
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 106

View PR using the GUI difftool:
$ git pr show -t 106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/106.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 30, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 303757b3a0d73329c954b28f08058fb60e5c9729 8319879: Stress mode to randomize incremental inlining decision Dec 30, 2023
@openjdk
Copy link

openjdk bot commented Dec 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 30, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 30, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 30, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 7, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319879: Stress mode to randomize incremental inlining decision

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 4bdda4b: 8322583: RISC-V: Enable fast class initialization checks
  • b3344f2: 8315731: Open source several Swing Text related tests
  • 49dd575: 8320921: GHA: Parallelize hotspot_compiler test jobs
  • 579c56f: 8322321: Add man page doc for -XX:+VerifySharedSpaces
  • 5f2cf88: 8322159: ThisEscapeAnalyzer crashes for erroneous code
  • 23a0b90: 8319548: Unexpected internal name for Filler array klass causes error in VisualVM
  • 9f60360: 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized
  • 58b1b0c: 8315042: NPE in PKCS7.parseOldSignedData
  • 57b5147: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
  • 966071a: 8309203: C2: remove copy-by-value of GrowableArray for InterfaceSet
  • ... and 6 more: https://git.openjdk.org/jdk21u-dev/compare/3465179458d844fec4d0496aa3d0c31b34c4c345...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 7, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

Going to push as commit dfc9324.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 307569f: 8319938: TestFileChooserSingleDirectorySelection.java fails with "getSelectedFiles returned empty array"
  • db1fa92: 8316594: C2 SuperWord: wrong result with hand unrolled loops
  • c8caefa: 8311279: TestStressIGVNAndCCP.java failed with different IGVN traces for the same seed
  • e8aa37d: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails
  • 854c319: 8319569: Several java/util tests should be updated to accept VM flags
  • 1f38afa: 8315097: Rename createJavaProcessBuilder
  • 4bdda4b: 8322583: RISC-V: Enable fast class initialization checks
  • b3344f2: 8315731: Open source several Swing Text related tests
  • 49dd575: 8320921: GHA: Parallelize hotspot_compiler test jobs
  • 579c56f: 8322321: Add man page doc for -XX:+VerifySharedSpaces
  • ... and 12 more: https://git.openjdk.org/jdk21u-dev/compare/3465179458d844fec4d0496aa3d0c31b34c4c345...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 8, 2024
@openjdk openjdk bot closed this Jan 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@GoeLin Pushed as commit dfc9324.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant