8328242: Add a log area to the PassFailJFrame

[toshiogata]

Hi all,

I would like to backport this patch to improve test maintainability for manual tests. The patch is clean.
Testing: manually checked some tests using PassFailJFrame, and confirmed that they work in the same way.

Thank you.

---

Progress

• JDK-8328242 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328242: Add a log area to the PassFailJFrame (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1061/head:pull/1061
$ git checkout pull/1061

Update a local copy of the PR:
$ git checkout pull/1061
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1061/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1061

View PR using the GUI difftool:
$ git pr show -t 1061

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1061.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back toshiogata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@toshiogata This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328242: Add a log area to the PassFailJFrame

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 9308dec: 8328402: Implement pausing functionality for the PassFailJFrame
• 42b3607: 8342669: [21u] Fix TestArrayAllocatorMallocLimit after backport of JDK-8315097
• 8a35e8f: 8341997: Tests create files in src tree instead of scratch dir
• b010fdc: 8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option
• c62b0a5: 8325610: CTW: Add StressIncrementalInlining to stress options
• a2f0ddb: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
• 5013360: 8341806: Gcc version detection failure on Alinux3
• 3fc07f2: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• 27d2abe: 8320892: AArch64: Restore FPU control state after JNI
• fe4b0fa: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
• ... and 20 more: https://git.openjdk.org/jdk21u-dev/compare/9e582fcbb8ab34b44ff01ac13de5cc4d6487396d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @toshiogata This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (4bcc5586)

[toshiogata]

/approval request I would like to backport this patch for test maintainability. The patch applies cleanly. The risk is low as this only touches tests. Testing: some manual tests using PassFailJFrame.

[openjdk]

@toshiogata
8328242: The approval request has been created successfully.

[toshiogata]

/integrate

[openjdk]

@toshiogata
Your change (at version 4bcc558) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 01e9dbd.
Since your change was applied there have been 32 commits pushed to the master branch:

• 826184c: 8323562: SaslInputStream.read() may return wrong value
• da87df7: 8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token
• 9308dec: 8328402: Implement pausing functionality for the PassFailJFrame
• 42b3607: 8342669: [21u] Fix TestArrayAllocatorMallocLimit after backport of JDK-8315097
• 8a35e8f: 8341997: Tests create files in src tree instead of scratch dir
• b010fdc: 8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option
• c62b0a5: 8325610: CTW: Add StressIncrementalInlining to stress options
• a2f0ddb: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
• 5013360: 8341806: Gcc version detection failure on Alinux3
• 3fc07f2: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
• ... and 22 more: https://git.openjdk.org/jdk21u-dev/compare/9e582fcbb8ab34b44ff01ac13de5cc4d6487396d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @toshiogata Pushed as commit 01e9dbd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.