8313374: --enable-ccache's CCACHE_BASEDIR breaks builds

[sendaoYan]

Hi all,

This pull request contains a backport of commit 571c435e from the openjdk/jdk repository.

The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson.

Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk21u-dev from jdk22.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8313374 needs maintainer approval

Issue

• JDK-8313374: --enable-ccache's CCACHE_BASEDIR breaks builds (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1066/head:pull/1066
$ git checkout pull/1066

Update a local copy of the PR:
$ git checkout pull/1066
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1066/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1066

View PR using the GUI difftool:
$ git pr show -t 1066

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1066.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313374: --enable-ccache's CCACHE_BASEDIR breaks builds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 9308dec: 8328402: Implement pausing functionality for the PassFailJFrame
• 42b3607: 8342669: [21u] Fix TestArrayAllocatorMallocLimit after backport of JDK-8315097
• 8a35e8f: 8341997: Tests create files in src tree instead of scratch dir
• b010fdc: 8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option
• c62b0a5: 8325610: CTW: Add StressIncrementalInlining to stress options
• a2f0ddb: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (be416ec1)

[sendaoYan]

/approval request Clean backport to fix build bug with --enable-ccache. Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR will fix the build issue. So I want to backport this PR to jdk21u-dev from jdk22.

[openjdk]

@sendaoYan
8313374: The approval request has been created successfully.

[sendaoYan]

Thanks for the approved.
/integrate

[openjdk]

@sendaoYan
Your change (at version be416ec) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit c37acdb.
Since your change was applied there have been 19 commits pushed to the master branch:

• 7dc0f7a: 8342701: [PPC64] TestOSRLotsOfLocals.java crashes
• 9ea9971: 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields
• c5be449: 8328379: Convert URLDragTest.html applet test to main
• 01eb688: 8195675: Call to insertText with single character from custom Input Method ignored
• 8818eb4: 8325506: Ensure randomness is only read from provided SecureRandom object
• d221709: 8320673: PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions
• 0dc59f8: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
• 9dbdaea: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
• f70c4bd: 8316428: G1: Nmethod count statistics only count last code root set iterated
• 9da2208: 8333824: Unused ClassValue in VarHandles
• ... and 9 more: https://git.openjdk.org/jdk21u-dev/compare/50133608f988fcfb2cca8f5a978722575f8d4849...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @sendaoYan Pushed as commit c37acdb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.