Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314610: hotspot can't compile with the latest of gtest because of <iomanip> #107

Closed

Conversation

jankratochvil
Copy link

@jankratochvil jankratochvil commented Jan 1, 2024

/home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp: In member function 'virtual void gc_memset_with_concurrent_readers_Test::TestBody()':
/home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp:82:34: error: 'setw' is not a member of 'std'
   82 |                          << std::setw(2) << line_byte(lp, 0) << " "
      |                                  ^~~~
/home/azul/azul/jdk21u-git/test/hotspot/gtest/gc/shared/test_memset_with_concurrent_readers.cpp:34:1: note: 'std::setw' is defined in header '<iomanip>'; did you forget to '#include <iomanip>'?
   33 | #include "unittest.hpp"
  +++ |+#include <iomanip>
   34 | 

Progress

  • JDK-8314610 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8314610: hotspot can't compile with the latest of gtest because of <iomanip> (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/107/head:pull/107
$ git checkout pull/107

Update a local copy of the PR:
$ git checkout pull/107
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 107

View PR using the GUI difftool:
$ git pr show -t 107

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/107.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 1, 2024

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport febc34dd285c3382716e068748d4a3b0c73d87ad 8314610: hotspot can't compile with the latest of gtest because of <iomanip> Jan 1, 2024
@openjdk
Copy link

openjdk bot commented Jan 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 1, 2024

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 1, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 2, 2024
@openjdk
Copy link

openjdk bot commented Jan 2, 2024

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314610: hotspot can't compile with the latest of gtest because of <iomanip>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 2, 2024
@jankratochvil
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 2, 2024
@openjdk
Copy link

openjdk bot commented Jan 2, 2024

@jankratochvil
Your change (at version e064a72) is now ready to be sponsored by a Committer.

@jankratochvil
Copy link
Author

I am just not sure whether the copyright year should be from the trunk commit (2023) or from this backport commit (2024).

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 2, 2024

Going to push as commit 3bf9212.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 2, 2024
@openjdk openjdk bot closed this Jan 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 2, 2024
@openjdk
Copy link

openjdk bot commented Jan 2, 2024

@phohensee @jankratochvil Pushed as commit 3bf9212.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants