Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature #1071

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 21, 2024

I backport this for parity with 21.0.6-oracle.

Skipped ProblemList, test is not listed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333317 needs maintainer approval

Issue

  • JDK-8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1071/head:pull/1071
$ git checkout pull/1071

Update a local copy of the PR:
$ git checkout pull/1071
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1071

View PR using the GUI difftool:
$ git pr show -t 1071

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1071.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 9da2208: 8333824: Unused ClassValue in VarHandles
  • 01e9dbd: 8328242: Add a log area to the PassFailJFrame
  • 826184c: 8323562: SaslInputStream.read() may return wrong value
  • da87df7: 8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token
  • 9308dec: 8328402: Implement pausing functionality for the PassFailJFrame
  • 42b3607: 8342669: [21u] Fix TestArrayAllocatorMallocLimit after backport of JDK-8315097
  • 8a35e8f: 8341997: Tests create files in src tree instead of scratch dir
  • b010fdc: 8340398: [JVMCI] Unintuitive behavior of UseJVMCICompiler option
  • c62b0a5: 8325610: CTW: Add StressIncrementalInlining to stress options

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c6f0a35e9e3eeaab1e238e8712051a626b337e0b 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature Oct 21, 2024
@openjdk
Copy link

openjdk bot commented Oct 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 21, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2024

Webrevs

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 22, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 31, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 31, 2024

Going to push as commit d7c85b1.
Since your change was applied there have been 27 commits pushed to the master branch:

  • c1a3c4f: 8335709: C2: assert(!loop->is_member(get_loop(useblock))) failed: must be outside loop
  • 86a7bab: 8325851: Hide PassFailJFrame.Builder constructor
  • c3cb940: 8342765: [21u] RTM tests assume UnlockExperimentalVMOptions is disabled by default
  • fa58ee0: 8338751: ConfigureNotify behavior has changed in KWin 6.2
  • f1b656d: 8337851: Some tests have name which confuse jtreg
  • e64c4f2: 8342962: [s390x] TestOSRLotsOfLocals.java crashes
  • bcd0958: 8315701: [macos] Regression: KeyEvent has different keycode on different keyboard layouts
  • 4845d80: 8283214: [macos] Screen magnifier does not show the magnified text for JComboBox
  • c37acdb: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds
  • 7dc0f7a: 8342701: [PPC64] TestOSRLotsOfLocals.java crashes
  • ... and 17 more: https://git.openjdk.org/jdk21u-dev/compare/a2f0ddbae8557e0ab6ba5344b775e6ca166899bf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2024
@openjdk openjdk bot closed this Oct 31, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2024
@openjdk
Copy link

openjdk bot commented Oct 31, 2024

@GoeLin Pushed as commit d7c85b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8333317 branch October 31, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants