8325506: Ensure randomness is only read from provided SecureRandom object

[GoeLin]

I backport this to improve testing in 21.
This also adds testing functionality (like asserts) needed by other tests.

The original change touches java.base. That change is not needed.
Instead, the functionality can be implemented right in the test.
I changed this to avoid unnecessary changes to the Java classes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8325506 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8325506: Ensure randomness is only read from provided SecureRandom object (Enhancement - P4 - Approved)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1074/head:pull/1074
$ git checkout pull/1074

Update a local copy of the PR:
$ git checkout pull/1074
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1074

View PR using the GUI difftool:
$ git pr show -t 1074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1074.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325506: Ensure randomness is only read from provided SecureRandom object

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 9da2208: 8333824: Unused ClassValue in VarHandles
• 01e9dbd: 8328242: Add a log area to the PassFailJFrame
• 826184c: 8323562: SaslInputStream.read() may return wrong value
• da87df7: 8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (79fb433d)

[GoeLin]

GHA failure: infra issue, unrelated.
] Downloading https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.8-bin.zip to /home/runner/work/jdk21u-dev/jdk21u-dev/jtreg/src/make/../build/deps/apache-ant-1.10.8-bin.zip
Error: sh][ERROR] wget exited with exit code 4

[RealLucy]

LGTM.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 8818eb4.
Since your change was applied there have been 8 commits pushed to the master branch:

• d221709: 8320673: PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions
• 0dc59f8: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
• 9dbdaea: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
• f70c4bd: 8316428: G1: Nmethod count statistics only count last code root set iterated
• 9da2208: 8333824: Unused ClassValue in VarHandles
• 01e9dbd: 8328242: Add a log area to the PassFailJFrame
• 826184c: 8323562: SaslInputStream.read() may return wrong value
• da87df7: 8311656: Shenandoah: Unused ShenandoahSATBAndRemarkThreadsClosure::_claim_token

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 8818eb4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.