Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 22, 2024

Clean backport of JDK-8342701.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8342701 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8342701: [PPC64] TestOSRLotsOfLocals.java crashes (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1076/head:pull/1076
$ git checkout pull/1076

Update a local copy of the PR:
$ git checkout pull/1076
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1076/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1076

View PR using the GUI difftool:
$ git pr show -t 1076

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1076.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342701: [PPC64] TestOSRLotsOfLocals.java crashes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 9ea9971: 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields
  • c5be449: 8328379: Convert URLDragTest.html applet test to main
  • 01eb688: 8195675: Call to insertText with single character from custom Input Method ignored
  • 8818eb4: 8325506: Ensure randomness is only read from provided SecureRandom object
  • d221709: 8320673: PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions
  • 0dc59f8: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
  • 9dbdaea: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
  • f70c4bd: 8316428: G1: Nmethod count statistics only count last code root set iterated
  • 9da2208: 8333824: Unused ClassValue in VarHandles
  • 01e9dbd: 8328242: Add a log area to the PassFailJFrame
  • ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/9308deceef913bbe64eb170a6c140d074c3a9660...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3bba0f3dc8faf83a3aadcd704ae2ae4967e6daa4 8342701: [PPC64] TestOSRLotsOfLocals.java crashes Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request Same as for JDK23.

@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@TheRealMDoerr
8342701: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 25, 2024
@TheRealMDoerr
Copy link
Contributor Author

GHA Test failure on Windows is obviously unrelated.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 29, 2024
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2024

Going to push as commit 7dc0f7a.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 9ea9971: 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields
  • c5be449: 8328379: Convert URLDragTest.html applet test to main
  • 01eb688: 8195675: Call to insertText with single character from custom Input Method ignored
  • 8818eb4: 8325506: Ensure randomness is only read from provided SecureRandom object
  • d221709: 8320673: PageFormat/CustomPaper.java has no Pass/Fail buttons; multiple instructions
  • 0dc59f8: 8322754: click JComboBox when dialog about to close causes IllegalComponentStateException
  • 9dbdaea: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.
  • f70c4bd: 8316428: G1: Nmethod count statistics only count last code root set iterated
  • 9da2208: 8333824: Unused ClassValue in VarHandles
  • 01e9dbd: 8328242: Add a log area to the PassFailJFrame
  • ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/9308deceef913bbe64eb170a6c140d074c3a9660...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2024
@openjdk openjdk bot closed this Oct 29, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2024
@openjdk
Copy link

openjdk bot commented Oct 29, 2024

@TheRealMDoerr Pushed as commit 7dc0f7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant