Skip to content

8316428: G1: Nmethod count statistics only count last code root set iterated#1096

Closed
jianglizhou wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-jianglizhou-fab372d3-master
Closed

8316428: G1: Nmethod count statistics only count last code root set iterated#1096
jianglizhou wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-jianglizhou-fab372d3-master

Conversation

@jianglizhou
Copy link
Contributor

@jianglizhou jianglizhou commented Oct 24, 2024

Auto suggested description:
This pull request contains a backport of commit fab372d3 from the openjdk/jdk repository.

The commit being backported was authored by Thomas Schatzl on 19 Sep 2023 and was reviewed by Ivan Walulya and Albert Mingkun Yang.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8316428 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8316428: G1: Nmethod count statistics only count last code root set iterated (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1096/head:pull/1096
$ git checkout pull/1096

Update a local copy of the PR:
$ git checkout pull/1096
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1096/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1096

View PR using the GUI difftool:
$ git pr show -t 1096

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1096.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2024

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

@jianglizhou This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316428: G1: Nmethod count statistics only count last code root set iterated

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fab372d3a23b17f64ae4306e28bdb0bc511f4912 8316428: G1: Nmethod count statistics only count last code root set iterated Oct 24, 2024
@openjdk
Copy link

openjdk bot commented Oct 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 24, 2024
@openjdk
Copy link

openjdk bot commented Oct 24, 2024

⚠️ @jianglizhou This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2024

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 24, 2024
@jianglizhou
Copy link
Contributor Author

https://bugs.openjdk.org/browse/JDK-8316428 backport for jdk21u-dev now has approval (thanks!).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 24, 2024
@jianglizhou
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2024

Going to push as commit f70c4bd.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2024
@openjdk openjdk bot closed this Oct 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2024
@openjdk
Copy link

openjdk bot commented Oct 25, 2024

@jianglizhou Pushed as commit f70c4bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant