-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328379: Convert URLDragTest.html applet test to main #1098
Conversation
👋 Welcome back toshiogata! A progress list of the required criteria for merging this PR into |
@toshiogata This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request I would like to backport this patch for test maintainability. The patch applies cleanly. The risk is low as this only touches tests. Testing: manually checks the modified test. |
@toshiogata |
/integrate |
@toshiogata |
/sponsor |
Going to push as commit c5be449.
Your commit was automatically rebased without conflicts. |
@phohensee @toshiogata Pushed as commit c5be449. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
I would like to backport this patch to improve test maintainability. The patch is clean.
Testing: manually checked URLDragTest.java, and confirmed that the test works in the same way.
Thank you.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1098/head:pull/1098
$ git checkout pull/1098
Update a local copy of the PR:
$ git checkout pull/1098
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1098/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1098
View PR using the GUI difftool:
$ git pr show -t 1098
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1098.diff
Webrev
Link to Webrev Comment