8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS

[GoeLin]

I backport this for parity with 21.0.6-oracle.

Backport command did not work, but my local patch applied clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8332901 needs maintainer approval

Issue

• JDK-8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1105/head:pull/1105
$ git checkout pull/1105

Update a local copy of the PR:
$ git checkout pull/1105
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1105

View PR using the GUI difftool:
$ git pr show -t 1105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1105.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS

Move SelectCurrentItemTest.java to java/awt/Choice/SelectItem/.
Move SelectNewItemTest.java to java/awt/Choice/SelectItem/.
Use latches to control test flow instead of delays.
Encapsulate the common logic in SelectCurrentItemTest.
Provide overridable checkXXX() methods to modify conditions.
Provide an overridable method which defines where to click
in the choice popup to select an item.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 7dc0f7a: 8342701: [PPC64] TestOSRLotsOfLocals.java crashes
• 9ea9971: 8334560: [PPC64]: postalloc_expand_java_dynamic_call_sched does not copy all fields
• c5be449: 8328379: Convert URLDragTest.html applet test to main

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[mlbridge]

Webrevs

• 00: Full (a213b7db)

[GoeLin]

/integrate

[openjdk]

Going to push as commit b0b4699.
Since your change was applied there have been 13 commits pushed to the master branch:

• d7c85b1: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature
• c1a3c4f: 8335709: C2: assert(!loop->is_member(get_loop(useblock))) failed: must be outside loop
• 86a7bab: 8325851: Hide PassFailJFrame.Builder constructor
• c3cb940: 8342765: [21u] RTM tests assume UnlockExperimentalVMOptions is disabled by default
• fa58ee0: 8338751: ConfigureNotify behavior has changed in KWin 6.2
• f1b656d: 8337851: Some tests have name which confuse jtreg
• e64c4f2: 8342962: [s390x] TestOSRLotsOfLocals.java crashes
• bcd0958: 8315701: [macos] Regression: KeyEvent has different keycode on different keyboard layouts
• 4845d80: 8283214: [macos] Screen magnifier does not show the magnified text for JComboBox
• c37acdb: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds
• ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/01eb688a001125dedc8c2cf454578aa352cd906a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit b0b4699.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[GoeLin]

GHA Failures: two times infra issue, unrelated.
[sh][ERROR] wget exited with exit code 4