Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325851: Hide PassFailJFrame.Builder constructor #1107

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 30, 2024

I backport this for parity with 21.0.6-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325851 needs maintainer approval

Issue

  • JDK-8325851: Hide PassFailJFrame.Builder constructor (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1107/head:pull/1107
$ git checkout pull/1107

Update a local copy of the PR:
$ git checkout pull/1107
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1107

View PR using the GUI difftool:
$ git pr show -t 1107

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1107.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 30, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325851: Hide PassFailJFrame.Builder constructor

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • c3cb940: 8342765: [21u] RTM tests assume UnlockExperimentalVMOptions is disabled by default
  • fa58ee0: 8338751: ConfigureNotify behavior has changed in KWin 6.2
  • f1b656d: 8337851: Some tests have name which confuse jtreg
  • e64c4f2: 8342962: [s390x] TestOSRLotsOfLocals.java crashes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3b9255eb663b4c90aa5cec89f0d9380ef8eba49e 8325851: Hide PassFailJFrame.Builder constructor Oct 30, 2024
@openjdk
Copy link

openjdk bot commented Oct 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Oct 30, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 30, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 30, 2024

GHA failure: infra issue, unrelated.
sh][ERROR] wget exited with exit code 4

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 31, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 31, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 31, 2024

Going to push as commit 86a7bab.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c3cb940: 8342765: [21u] RTM tests assume UnlockExperimentalVMOptions is disabled by default
  • fa58ee0: 8338751: ConfigureNotify behavior has changed in KWin 6.2
  • f1b656d: 8337851: Some tests have name which confuse jtreg
  • e64c4f2: 8342962: [s390x] TestOSRLotsOfLocals.java crashes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 31, 2024
@openjdk openjdk bot closed this Oct 31, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2024
@openjdk
Copy link

openjdk bot commented Oct 31, 2024

@GoeLin Pushed as commit 86a7bab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant