8338389: [JFR] Long strings should be added to the string pool

[SoniaZaldana]

Hi all,

This pull request contains a backport of commit d5c6158c from the openjdk/jdk repository.

The commit being backported was authored by Joakim Nordström on 27 Aug 2024 and was reviewed by Markus Grönlund.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8338389 needs maintainer approval

Issue

• JDK-8338389: [JFR] Long strings should be added to the string pool (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1109/head:pull/1109
$ git checkout pull/1109

Update a local copy of the PR:
$ git checkout pull/1109
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1109

View PR using the GUI difftool:
$ git pr show -t 1109

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1109.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338389: [JFR] Long strings should be added to the string pool

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

• bcc85d9: 8318442: java/net/httpclient/ManyRequests2.java fails intermittently on Linux
• 6affc09: 8340801: Disable ubsan checks in some awt/2d coding
• 1af737e: 8339892: Several security shell tests don't set TESTJAVAOPTS
• d0abff2: 8207908: JMXStatusTest.java fails assertion intermittently
• c5d75ef: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags
• d81d301: 8342181: Update tests to use stronger Key and Salt size
• 22d5e0d: 8343474: [updates] Customize README.md to specifics of update project
• 9bdf2a6: 8341927: Replace hardcoded security providers with new test.provider.name system property
• 7869713: 8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp
• 2702f67: 8333235: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with C1
• ... and 42 more: https://git.openjdk.org/jdk21u-dev/compare/bcd095826fba92f57d0648b7905edf6f7fee416f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (cb0b5584)

[SoniaZaldana]

/integrate

[openjdk]

Going to push as commit 948710f.
Since your change was applied there have been 63 commits pushed to the master branch:

• b9c83b5: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask'
• a4927ca: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
• f36b3b4: 8336911: ZGC: Division by zero in heuristics after JDK-8332717
• 4f6c506: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
• 38f654e: 8343724: [PPC64] Disallow OptoScheduling
• 1bfb57d: 8342607: Enhance register printing on x86_64 platforms
• fe41d0a: 8343506: [s390x] multiple test failures with ubsan
• e1eb341: 8342183: Update tests to use stronger algorithms and keys
• 0fd3173: 8342188: Update tests to use stronger key parameters and certificates
• 5b1a952: 8336257: Additional tests in jmxremote/startstop to match on PID not app name
• ... and 53 more: https://git.openjdk.org/jdk21u-dev/compare/bcd095826fba92f57d0648b7905edf6f7fee416f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@SoniaZaldana Pushed as commit 948710f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.