Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() #1122

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Nov 4, 2024

clean backport of JDK-8340824


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340824 needs maintainer approval

Issue

  • JDK-8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1122/head:pull/1122
$ git checkout pull/1122

Update a local copy of the PR:
$ git checkout pull/1122
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1122

View PR using the GUI difftool:
$ git pr show -t 1122

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1122.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2024

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2024

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

  • 17ba513: 8345370: Bump update version for OpenJDK: jdk-21.0.7
  • e45287d: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
  • 3f648b4: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux
  • 96a3a88: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21
  • d383ba5: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
  • e569997: 8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails
  • 92aa77c: 8343285: java.lang.Process is unresponsive and CPU usage spikes to 100%
  • 046c4aa: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set
  • a803b5a: 8342409: [s390x] C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR
  • 5ac01de: 8345055: [21u] ProblemList failing rtm tests on ppc platforms
  • ... and 57 more: https://git.openjdk.org/jdk21u-dev/compare/c17e00945d0b06f7459a3dbb091321cfe3dc6129...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 90c944fefe4a7827c08a8e6a81f137c3157a749b 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() Nov 4, 2024
@openjdk
Copy link

openjdk bot commented Nov 4, 2024

This backport pull request has now been updated with issue from the original commit.

@rwestrel rwestrel marked this pull request as ready for review November 4, 2024 15:29
@openjdk
Copy link

openjdk bot commented Nov 4, 2024

⚠️ @rwestrel This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 4, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 4, 2024

Webrevs

@openjdk openjdk bot added the approval label Nov 4, 2024
@GoeLin
Copy link
Member

GoeLin commented Nov 5, 2024

Hi @rwestrel, should we target 21.0.7 as oracle does? This has no coverage in a released version yet and is brand new.

@rwestrel
Copy link
Contributor Author

rwestrel commented Nov 5, 2024

@GoeLin that would be fine with me. What would be the process then? Do I need to close this one for now and re-apply for approval later on?

@jerboaa
Copy link
Contributor

jerboaa commented Nov 5, 2024

@GoeLin that would be fine with me. What would be the process then? Do I need to close this one for now and re-apply for approval later on?

Not Götz, but you can keep the PR open and we'll approve once 21.0.7 development opens. At that point the PR would move to the ready state.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2024

@rwestrel This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jerboaa
Copy link
Contributor

jerboaa commented Dec 3, 2024

Keep open. 21.0.7 development starts this Thursday.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 4, 2024

jdk21u-dev is now 21.0.7 development. Approved. Feel free to integrate @rwestrel

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 4, 2024
@rwestrel
Copy link
Contributor Author

rwestrel commented Dec 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

Going to push as commit 1f6b401.
Since your change was applied there have been 72 commits pushed to the master branch:

  • c2c40df: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java
  • eb29579: 8334490: Normalize string with locale invariant toLowerCase()
  • 2909f65: 8336012: Fix usages of jtreg-reserved properties
  • 64f0263: 8331993: Add counting leading/trailing zero tests for Integer
  • f7ba9cc: 8327390: JitTester: Implement temporary folder functionality
  • 17ba513: 8345370: Bump update version for OpenJDK: jdk-21.0.7
  • e45287d: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
  • 3f648b4: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux
  • 96a3a88: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21
  • d383ba5: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order
  • ... and 62 more: https://git.openjdk.org/jdk21u-dev/compare/c17e00945d0b06f7459a3dbb091321cfe3dc6129...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2024
@openjdk openjdk bot closed this Dec 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@rwestrel Pushed as commit 1f6b401.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants