Skip to content

8306446: java/lang/management/ThreadMXBean/Locks.java transient failures #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 5, 2024

Hi all,

This pull request contains a backport of commit 4ae5a3e3 from the openjdk/jdk repository.

The commit being backported was authored by Kevin Walls on 28 Jul 2023 and was reviewed by Chris Plummer and Serguei Spitsyn.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8306446 needs maintainer approval

Issue

  • JDK-8306446: java/lang/management/ThreadMXBean/Locks.java transient failures (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1125/head:pull/1125
$ git checkout pull/1125

Update a local copy of the PR:
$ git checkout pull/1125
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1125

View PR using the GUI difftool:
$ git pr show -t 1125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1125.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306446: java/lang/management/ThreadMXBean/Locks.java transient failures

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 34021e9: 8333728: ubsan: shenandoahFreeSet.cpp:1347:24: runtime error: division by zero

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4ae5a3e39b681bfd001df1483d8a6d1fce0bc7f8 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport from jdk22 to jdk21u-dev, to make this test run passed with TEST_THREAD_FACTORY=Virtual. Before apply this backport patch, this test run fails with TEST_THREAD_FACTORY=Virtual, after apply this backport patch, this test run pass with TEST_THREAD_FACTORY=Virtual. The change has been verified locally on linux-x64 and linux-aarch64. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@sendaoYan
8306446: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Nov 5, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@sendaoYan
Your change (at version 0c953df) is now ready to be sponsored by a Committer.

@kevinjwalls
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

Going to push as commit 6b4be01.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 34021e9: 8333728: ubsan: shenandoahFreeSet.cpp:1347:24: runtime error: division by zero

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 5, 2024
@openjdk openjdk bot closed this Nov 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 5, 2024
@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@kevinjwalls @sendaoYan Pushed as commit 6b4be01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants