8339892: Several security shell tests don't set TESTJAVAOPTS

[sendaoYan]

Hi all,

This pull request contains a backport of commit 8a2a75e5 from the openjdk/jdk repository.

The commit being backported was authored by Sonia Zaldana Calles on 12 Nov 2024 and was reviewed by Valerie Peng.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8339892 needs maintainer approval

Issue

• JDK-8339892: Several security shell tests don't set TESTJAVAOPTS (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1147/head:pull/1147
$ git checkout pull/1147

Update a local copy of the PR:
$ git checkout pull/1147
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1147

View PR using the GUI difftool:
$ git pr show -t 1147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1147.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339892: Several security shell tests don't set TESTJAVAOPTS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• d81d301: 8342181: Update tests to use stronger Key and Salt size
• 22d5e0d: 8343474: [updates] Customize README.md to specifics of update project

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (b2cd9e17)

[sendaoYan]

GHA report a test failure

1. macos-aarch64 job at install toolchain and dependencies stage fails invalid developer directory seems like environmental issue, it's unreleated to this issue.

[sendaoYan]

/approval request Clean backport to make several shell tests recevie 'TESTJAVAOPTS' args, test-fix only, no risk.

[openjdk]

@sendaoYan
8339892: The approval request has been created successfully.

[sendaoYan]

Thanks for the approved.

/integrate

[openjdk]

Going to push as commit 1af737e.
Since your change was applied there have been 4 commits pushed to the master branch:

• d0abff2: 8207908: JMXStatusTest.java fails assertion intermittently
• c5d75ef: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags
• d81d301: 8342181: Update tests to use stronger Key and Salt size
• 22d5e0d: 8343474: [updates] Customize README.md to specifics of update project

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 1af737e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.