Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 18, 2024

I backport this for parity with 21.0.5-oracle.

I include follow-up 8336315.

Both are clean backports. Test passes on win.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336315 needs maintainer approval
  • JDK-8325525 needs maintainer approval

Issues

  • JDK-8325525: Create jtreg test case for JDK-8325203 (Enhancement - P4 - Approved)
  • JDK-8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1160/head:pull/1160
$ git checkout pull/1160

Update a local copy of the PR:
$ git checkout pull/1160
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1160

View PR using the GUI difftool:
$ git pr show -t 1160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1160.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325525: Create jtreg test case for JDK-8325203
8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • cb9a6a2: 8333144: docker tests do not work when ubsan is configured
  • fd7b6e4: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate
  • 324e32f: 8321470: ThreadLocal.nextHashCode can be static final
  • 4b1365e: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners
  • 948710f: 8338389: [JFR] Long strings should be added to the string pool
  • b9c83b5: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask'
  • a4927ca: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
  • f36b3b4: 8336911: ZGC: Division by zero in heuristics after JDK-8332717
  • 4f6c506: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
  • 38f654e: 8343724: [PPC64] Disallow OptoScheduling
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/fe41d0a2e1e951c8f8a9e3842d3fe768f4fc604f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the title Goetz backport 8325525 Backport 81a0d1ba03bbdbe718302b3925cdc207d5d05232 Nov 18, 2024
@openjdk openjdk bot changed the title Backport 81a0d1ba03bbdbe718302b3925cdc207d5d05232 8325525: Create jtreg test case for JDK-8325203 Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 18, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Nov 18, 2024

/issue JDK-8325203

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@GoeLin
Adding additional issue to issue list: 8325203: System.exit(0) kills the launched 3rd party application.

@mlbridge
Copy link

mlbridge bot commented Nov 18, 2024

Webrevs

@kevinrushforth
Copy link
Member

@GoeLin This PR should not list JDK-8325203 as an additional issue, since that bug has already been backported to jdk21u-dev.

@GoeLin
Copy link
Member Author

GoeLin commented Nov 18, 2024

/issue 8336315

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@GoeLin
Adding additional issue to issue list: 8336315: tools/jpackage/windows/WinChildProcessTest.java Failed: Check is calculator process is alive.

@GoeLin
Copy link
Member Author

GoeLin commented Nov 18, 2024

@kevinrushforth, thanks, I mistyped the bugid.

@GoeLin
Copy link
Member Author

GoeLin commented Nov 18, 2024

/issue remove JDK-8325203

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@GoeLin
Removing additional issue from issue list: 8325203.

@GoeLin
Copy link
Member Author

GoeLin commented Nov 19, 2024

GHA failure: infra issue, unrelated.
Error: sh][ERROR] wget exited with exit code 4

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 19, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Nov 20, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

Going to push as commit 936b239.
Since your change was applied there have been 11 commits pushed to the master branch:

  • cb9a6a2: 8333144: docker tests do not work when ubsan is configured
  • fd7b6e4: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate
  • 324e32f: 8321470: ThreadLocal.nextHashCode can be static final
  • 4b1365e: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners
  • 948710f: 8338389: [JFR] Long strings should be added to the string pool
  • b9c83b5: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask'
  • a4927ca: 8338449: ubsan: division by zero in sharedRuntimeTrans.cpp
  • f36b3b4: 8336911: ZGC: Division by zero in heuristics after JDK-8332717
  • 4f6c506: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
  • 38f654e: 8343724: [PPC64] Disallow OptoScheduling
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/fe41d0a2e1e951c8f8a9e3842d3fe768f4fc604f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2024
@openjdk openjdk bot closed this Nov 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@GoeLin Pushed as commit 936b239.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8325525 branch November 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants