Skip to content

Conversation

@alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Nov 19, 2024

I'd like to backport it as a follow-up for JDK-8179502

Backport is clean
All related JTREG tests passed


Progress

  • Change must not contain extraneous whitespace
  • JDK-8337826 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 (Enhancement - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1162/head:pull/1162
$ git checkout pull/1162

Update a local copy of the PR:
$ git checkout pull/1162
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1162

View PR using the GUI difftool:
$ git pr show -t 1162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1162.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

@alexeybakhtin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • cb9a6a2: 8333144: docker tests do not work when ubsan is configured
  • fd7b6e4: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9b11bd7f4a511ddadf9f02e82aab6ba78beb6763 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 Nov 19, 2024
@openjdk
Copy link

openjdk bot commented Nov 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 19, 2024
@openjdk
Copy link

openjdk bot commented Nov 19, 2024

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2024

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 19, 2024
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot added rfr Pull request is ready for review ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 20, 2024
@alexeybakhtin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

Going to push as commit 2029e4e.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f9cd285: 8338550: Do libubsan1 installation in test container only if requested
  • 936b239: 8325525: Create jtreg test case for JDK-8325203
  • cb9a6a2: 8333144: docker tests do not work when ubsan is configured
  • fd7b6e4: 8336640: Shenandoah: Parallel worker use in parallel_heap_region_iterate

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2024
@openjdk openjdk bot closed this Nov 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@alexeybakhtin Pushed as commit 2029e4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant