Skip to content

8343884: [s390x] Disallow OptoScheduling #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Nov 20, 2024

Hi all,

This pull request contains a backport of commit 7540fa21 from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 19 Nov 2024 and was reviewed by Lutz Schmidt.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343884 needs maintainer approval

Issue

  • JDK-8343884: [s390x] Disallow OptoScheduling (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1164/head:pull/1164
$ git checkout pull/1164

Update a local copy of the PR:
$ git checkout pull/1164
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1164

View PR using the GUI difftool:
$ git pr show -t 1164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1164.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343884: [s390x]  Disallow OptoScheduling

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 2029e4e: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
  • f9cd285: 8338550: Do libubsan1 installation in test container only if requested
  • 936b239: 8325525: Create jtreg test case for JDK-8325203
  • cb9a6a2: 8333144: docker tests do not work when ubsan is configured

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 7540fa2147ff8fc9c652ef13548f72f27e2809a8 8343884: [s390x] Disallow OptoScheduling Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024
@offamitkumar
Copy link
Member Author

/approval request OptoScheduling is not supported on s390x, so it has to be disabled on the architecture. No regression, s390x specific, low risk.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@offamitkumar
8343884: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 20, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2024

Webrevs

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot added rfr Pull request is ready for review ready Pull request is ready to be integrated and removed approval labels Nov 20, 2024
@offamitkumar
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@offamitkumar
Your change (at version 2714827) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

Going to push as commit 50fc231.
Since your change was applied there have been 9 commits pushed to the master branch:

  • f091c76: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64
  • 4bbc29c: 8319678: Several tests from corelibs areas ignore VM flags
  • add7934: 8339637: (tz) Update Timezone Data to 2024b
  • 322fc81: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
  • 3aa59b3: 8341722: Fix some warnings as errors when building on Linux with toolchain clang
  • 2029e4e: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
  • f9cd285: 8338550: Do libubsan1 installation in test container only if requested
  • 936b239: 8325525: Create jtreg test case for JDK-8325203
  • cb9a6a2: 8333144: docker tests do not work when ubsan is configured

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2024
@openjdk openjdk bot closed this Nov 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@phohensee @offamitkumar Pushed as commit 50fc231.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants