8341424: GHA: Collect hs_errs from build time failures

[vieiro]

Backport of JDK-8341424 and companion JDK-8342704

This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews. The idea is to backport this to 17 and 11 too.

Low risk, as this affects GHA actions only. GHA builds and tests run correctly.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8342704 needs maintainer approval
• JDK-8341424 needs maintainer approval

Issues

• JDK-8341424: GHA: Collect hs_errs from build time failures (Enhancement - P4 - Approved)
• JDK-8342704: GHA: Report truncation is broken after JDK-8341424 (Bug - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1175/head:pull/1175
$ git checkout pull/1175

Update a local copy of the PR:
$ git checkout pull/1175
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1175

View PR using the GUI difftool:
$ git pr show -t 1175

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1175.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vieiro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341424: GHA: Collect hs_errs from build time failures
8342704: GHA: Report truncation is broken after JDK-8341424

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 78 new commits pushed to the master branch:

• eaa475f: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
• 227c430: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform
• 1c53e8c: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main
• c0336dd: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
• 0a65f3c: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main
• 57973b7: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• cce9336: 8316371: Open some swing tests 6
• 0cdb868: 8316218: Open some swing tests 5
• 0cb7705: 8316146: Open some swing tests 4
• 85453b6: 8315882: Open some swing tests 2
• ... and 68 more: https://git.openjdk.org/jdk21u-dev/compare/50fc231b04c0e97d74ad2d6bb97096d924bd3f0f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[vieiro]

/issue add JDK-8341424

[openjdk]

@vieiro
Adding additional issue to issue list: 8341424: GHA: Collect hs_errs from build time failures.

[mlbridge]

Webrevs

• 00: Full (9039c4d6)

[shipilev]

This looks fine, thanks.

I found it a bit inconvenient to title this PR as "JDK-8342704: GHA: Report truncation is broken after JDK-8341424", and not as "JDK-8341424): GHA: Collect hs_errs from build time failures", but this is a technicality that does not affect much.

[openjdk]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[vieiro]

@shipilev Thank you! Yep, I thought of changing the title, too, but then I forgot. I'll try to do that in 17u.
Thinking of it twice, let's change the title now.

[vieiro]

/approval request Let's collect those hs_err files from build time failures in GHA so we can take a look at them!

[openjdk]

@vieiro
8342704: The approval request has been created successfully.
8341424: The approval request has been created successfully.

[vieiro]

/issue add JDK-8342704

[openjdk]

@vieiro
Adding additional issue to issue list: 8342704: GHA: Report truncation is broken after JDK-8341424.

[vieiro]

/integrate

[openjdk]

@vieiro
Your change (at version 9039c4d) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 0011704.
Since your change was applied there have been 78 commits pushed to the master branch:

• eaa475f: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
• 227c430: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform
• 1c53e8c: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main
• c0336dd: 8328717: Convert javax/swing/JColorChooser/8065098/bug8065098.java applet test to main
• 0a65f3c: 8328370: Convert java/awt/print/Dialog/PrintApplet.java applet test to main
• 57973b7: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main
• cce9336: 8316371: Open some swing tests 6
• 0cdb868: 8316218: Open some swing tests 5
• 0cb7705: 8316146: Open some swing tests 4
• 85453b6: 8315882: Open some swing tests 2
• ... and 68 more: https://git.openjdk.org/jdk21u-dev/compare/50fc231b04c0e97d74ad2d6bb97096d924bd3f0f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @vieiro Pushed as commit 0011704.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.