-
Notifications
You must be signed in to change notification settings - Fork 122
8316893: Compile without -fno-delete-null-pointer-checks #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316893: Compile without -fno-delete-null-pointer-checks #1178
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
GHA report a failure:
|
/approval request Clean backport to remove gcc option |
@sendaoYan |
Thanks for the approved. /integrate |
@sendaoYan Pushed as commit 7045581. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
There are some gcc compile warnings which recorded by JDK-8342304 on linux-riscv64 platform, and the PR JDK-8316893 fix the gcc compile warnings. So I want to backport JDK-8316893 to jdk21u-dev.
Additional testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1178/head:pull/1178
$ git checkout pull/1178
Update a local copy of the PR:
$ git checkout pull/1178
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1178/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1178
View PR using the GUI difftool:
$ git pr show -t 1178
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1178.diff
Using Webrev
Link to Webrev Comment