Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized #119

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 4, 2024

Clean backport to fix C2 regression in JDK 21.

Additional testing:

  • New regression test passes even without a fix
  • linux-x86_64-server-fastdebug, tier{1,2,3}

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321974 needs maintainer approval

Issue

  • JDK-8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/119/head:pull/119
$ git checkout pull/119

Update a local copy of the PR:
$ git checkout pull/119
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 119

View PR using the GUI difftool:
$ git pr show -t 119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/119.diff

Webrev

Link to Webrev Comment

@shipilev shipilev marked this pull request as ready for review January 4, 2024 09:21
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 4, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c8ad7b7f84ead3f850f034e1db6335bbbac41589 8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 4, 2024
@shipilev
Copy link
Member Author

shipilev commented Jan 4, 2024

/approval request Clean backport to fix C2 regression in JDK 21. Applies cleanly. The regression test, unfortunately, still passes without the fix.

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@shipilev
8321974: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 4, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321974: Crash in ciKlass::is_subtype_of because TypeAryPtr::_klass is not initialized

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 58b1b0c: 8315042: NPE in PKCS7.parseOldSignedData
  • 57b5147: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 5, 2024
@shipilev
Copy link
Member Author

shipilev commented Jan 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

Going to push as commit 9f60360.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 58b1b0c: 8315042: NPE in PKCS7.parseOldSignedData
  • 57b5147: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 5, 2024
@openjdk openjdk bot closed this Jan 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

@shipilev Pushed as commit 9f60360.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8321974-is-subtype branch February 7, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant