Skip to content

Conversation

@SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Dec 2, 2024

Hi all,

This pull request contains a backport of commit e6c5aa7a from the openjdk/jdk repository.

The commit being backported was authored by Christian Stein on 10 Jul 2024 and was reviewed by Jonathan Gibbons.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336012 needs maintainer approval

Issue

  • JDK-8336012: Fix usages of jtreg-reserved properties (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1196/head:pull/1196
$ git checkout pull/1196

Update a local copy of the PR:
$ git checkout pull/1196
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1196

View PR using the GUI difftool:
$ git pr show -t 1196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1196.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336012: Fix usages of jtreg-reserved properties

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 17ba513: 8345370: Bump update version for OpenJDK: jdk-21.0.7
  • e45287d: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
  • 3f648b4: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux
  • 96a3a88: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e6c5aa7a6cb54c647d261facdcffa6a410849627 8336012: Fix usages of jtreg-reserved properties Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 2, 2024
@SoniaZaldana SoniaZaldana marked this pull request as ready for review December 3, 2024 21:27
@openjdk openjdk bot added approval Requires approval; will be removed when approval is received rfr Pull request is ready for review labels Dec 3, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 4, 2024
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

Going to push as commit 2909f65.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 64f0263: 8331993: Add counting leading/trailing zero tests for Integer
  • f7ba9cc: 8327390: JitTester: Implement temporary folder functionality
  • 17ba513: 8345370: Bump update version for OpenJDK: jdk-21.0.7
  • e45287d: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
  • 3f648b4: 8342905: Thread.setContextClassloader from thread in FJP commonPool task no longer works after JDK-8327501 redux
  • 96a3a88: 8344993: [21u] [REDO] Backport JDK-8327501 and JDK-8328366 to JDK 21

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2024
@openjdk openjdk bot closed this Dec 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@SoniaZaldana Pushed as commit 2909f65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant