Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 4, 2024

I backport this for parity with 21.0.7-oracle


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324672 needs maintainer approval

Issue

  • JDK-8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1206/head:pull/1206
$ git checkout pull/1206

Update a local copy of the PR:
$ git checkout pull/1206
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1206

View PR using the GUI difftool:
$ git pr show -t 1206

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1206.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 71bf10e: 8341862: PPC64: C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e94e3bba3932f3d92c0a135d333d1ccd6e72b964 8324672: Update jdk/java/time/tck/java/time/TCKInstant.java now() to be more robust Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 6, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Dec 6, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2024

Going to push as commit 532c49a.
Since your change was applied there have been 7 commits pushed to the master branch:

  • d0f15d5: 8339261: Logs truncated in test javax/net/ssl/DTLS/DTLSRehandshakeTest.java
  • e2daa35: 8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation
  • f554fcf: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F
  • 739b5fb: 8333391: Test com/sun/jdi/InterruptHangTest.java failed: Thread was never interrupted during sleep
  • a3788f2: 8335789: [TESTBUG] XparColor.java test fails with Error. Parse Exception: Invalid or unrecognized bugid: @
  • da281fa: 8327857: Remove applet usage from JColorChooser tests Test4222508
  • 71bf10e: 8341862: PPC64: C1 unwind_handler fails to unlock synchronized methods with LM_MONITOR

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2024
@openjdk openjdk bot closed this Dec 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2024
@openjdk
Copy link

openjdk bot commented Dec 6, 2024

@GoeLin Pushed as commit 532c49a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant