Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317919: pthread_attr_init handle return value and destroy pthread_attr_t object #1235

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 16, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317919 needs maintainer approval

Issue

  • JDK-8317919: pthread_attr_init handle return value and destroy pthread_attr_t object (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1235/head:pull/1235
$ git checkout pull/1235

Update a local copy of the PR:
$ git checkout pull/1235
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1235

View PR using the GUI difftool:
$ git pr show -t 1235

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1235.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317919: pthread_attr_init handle return value and destroy pthread_attr_t object

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b682b1f: 8336498: [macos] [build]: install-file macro may run into permission denied error

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ec310fe80971261ab7ee1141c64ffd600e7546c0 8317919: pthread_attr_init handle return value and destroy pthread_attr_t object Dec 16, 2024
@openjdk
Copy link

openjdk bot commented Dec 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Dec 16, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

Going to push as commit 2867acd.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 3d71029: 8328403: Remove applet usage from JColorChooser tests Test6977726
  • 544c4b5: 8328227: Remove applet usage from JColorChooser tests Test4887836
  • 52daaa9: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main
  • 7478c4b: 8328380: Remove applet usage from JColorChooser tests Test6348456
  • 8c58f66: 8328121: Remove applet usage from JColorChooser tests Test4759306
  • fa46166: 8327859: Remove applet usage from JColorChooser tests Test4319113
  • a21862a: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate()
  • 1c69135: 8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values
  • b682b1f: 8336498: [macos] [build]: install-file macro may run into permission denied error

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2024
@openjdk openjdk bot closed this Dec 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

@MBaesken Pushed as commit 2867acd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant