8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize

[yaqsun]

runtime/cds/appcds/TestZGCWithCDS.java#ZGenerational failed, we want to make the test pass.
Patch can be applied cleanly.
Low risk.
And test have been locally verified to pass.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8316319 needs maintainer approval

Issue

• JDK-8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/126/head:pull/126
$ git checkout pull/126

Update a local copy of the PR:
$ git checkout pull/126
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/126/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 126

View PR using the GUI difftool:
$ git pr show -t 126

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/126.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @yaqsun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 02: Full - Incremental (7d5588ad)
• 01: Full - Incremental (be07444b)
• 00: Full (4be4685f)

[shipilev]

It looks fine, but you need to go to https://github.com/yaqsun/jdk21u-dev/actions, enable the testing workflow, and kick off the test run. Then apply for maintainer approval, like bot above says.

[yaqsun]

/approval

[openjdk]

@yaqsun usage: /approval [<id>] (request|cancel) [<text>]

[yaqsun]

/approval 8316319 request

[openjdk]

@yaqsun
8316319: The approval request has been created successfully.

[GoeLin]

Hi,
your approval request is not complete.
Please list reason, risk, testing and whether
the backport was clean. See also
https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix "Example Fix Request comment".
Removing label in the meantime.

[yaqsun]

/approval 8316319 request

[openjdk]

@yaqsun
8316319: The approval request was already up to date.

[openjdk]

@yaqsun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the master branch:

• ada400c: 8318158: RISC-V: implement roundD/roundF intrinsics
• 1dd2f2a: 8169475: WheelModifier.java fails by timeout
• e9be531: 8077371: Binary files in JAXP test should be removed
• 69416f4: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
• c01bdbb: 8314283: Support for NSS tests on aarch64 platforms
• c3657ee: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma
• 95e36bc: 8322279: Generational ZGC: Use ZFragmentationLimit and ZYoungCompactionLimit as percentage instead of multiples
• 6443937: 8323008: filter out harmful -std* flags added by autoconf from CXX
• c8f0418: 8310031: Parallel: Implement better work distribution for large object arrays in old gen
• 0d30c8d: 8318590: JButton ignores margin when painting HTML text
• ... and 108 more: https://git.openjdk.org/jdk21u-dev/compare/57b5147260464214122cb5200566c2b4d2889c75...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

@yaqsun, I think you are ready to integrate.

[yaqsun]

/integrate

[openjdk]

@yaqsun
Your change (at version 7d5588a) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 8084244.
Since your change was applied there have been 122 commits pushed to the master branch:

• 2697a9d: 8318696: Do not use LFS64 symbols on Linux
• 1f9b03e: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
• be8733b: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils
• fae1a03: 8312416: Tests in Locale should have more descriptive names
• ada400c: 8318158: RISC-V: implement roundD/roundF intrinsics
• 1dd2f2a: 8169475: WheelModifier.java fails by timeout
• e9be531: 8077371: Binary files in JAXP test should be removed
• 69416f4: 8318809: java/util/concurrent/ConcurrentLinkedQueue/WhiteBox.java shows intermittent failures on linux ppc64le and aarch64
• c01bdbb: 8314283: Support for NSS tests on aarch64 platforms
• c3657ee: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma
• ... and 112 more: https://git.openjdk.org/jdk21u-dev/compare/57b5147260464214122cb5200566c2b4d2889c75...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @yaqsun Pushed as commit 8084244.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.