8340313: Crash due to invalid oop in nmethod after C1 patching

[GoeLin]

I backport this for parity with 21.0.7-oracle.

I had to do trivial resolves:

src/hotspot/cpu/riscv/nativeInst_riscv.cpp
The first lock to be changed already uses CodeCache_lock.

src/hotspot/share/runtime/mutexLocker.cpp/hpp
Resolved due to context

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8340313 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8340313: Crash due to invalid oop in nmethod after C1 patching (Bug - P2 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1284/head:pull/1284
$ git checkout pull/1284

Update a local copy of the PR:
$ git checkout pull/1284
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1284

View PR using the GUI difftool:
$ git pr show -t 1284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1284.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340313: Crash due to invalid oop in nmethod after C1 patching

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 8a5bbfe: 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor
• 4474fbc: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 2f89954: 8339883: Open source several AWT/2D related tests
• d4c5d69: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null'
• 36b067c: 8345414: Google CAInterop test failures
• 182e949: 8342602: Remove JButton/PressedButtonRightClickTest test
• fe9284a: 8343101: Rework BasicTest.testTemp test cases
• 85e5a5c: 8335288: SunPKCS11 initialization will call C_GetMechanismInfo on unsupported mechanisms
• bf86b34: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java
• 173c3d3: 8333647: C2 SuperWord: some additional PopulateIndex tests
• ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/c7c7280f6e25fb68950bad93aa20a96cfc9f35b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (20b3b31e)

[GoeLin]

GHA failure: Twice well konwn wget issue, unrelated.

[TheRealMDoerr]

LGTM.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

/integrate

[openjdk]

Going to push as commit d912330.
Since your change was applied there have been 18 commits pushed to the master branch:

• 60bf039: 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java
• ff7e184: 8328558: Convert javax/swing/JCheckBox/8032667/bug8032667.java applet test to main
• cf36052: 8315825: Open some swing tests
• 3b8d404: 8313905: Checked_cast assert in CDS compare_by_loader
• 8a5bbfe: 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor
• 4474fbc: 8342609: jpackage test helper function incorrectly removes a directory instead of its contents only
• 2f89954: 8339883: Open source several AWT/2D related tests
• d4c5d69: 8321818: vmTestbase/nsk/stress/strace/strace015.java failed with 'Cannot read the array length because "" is null'
• 36b067c: 8345414: Google CAInterop test failures
• 182e949: 8342602: Remove JButton/PressedButtonRightClickTest test
• ... and 8 more: https://git.openjdk.org/jdk21u-dev/compare/c7c7280f6e25fb68950bad93aa20a96cfc9f35b3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit d912330.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.