Skip to content

8314752: Use google test string comparison macros #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 8, 2025

I backport this for parity with 21.0.7-oracle.

test/hotspot/gtest/logging/test_logConfiguration.cpp
I had to resolve because
"8299825: Move StdoutLog and StderrLog to LogConfiguration" is not in 21.

test/hotspot/gtest/oops/test_cpCache_output.cpp
8301996: Move field resolution information out of the cpCache not in 21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314752 needs maintainer approval

Issue

  • JDK-8314752: Use google test string comparison macros (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1305/head:pull/1305
$ git checkout pull/1305

Update a local copy of the PR:
$ git checkout pull/1305
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1305

View PR using the GUI difftool:
$ git pr show -t 1305

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1305.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 8, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314752: Use google test string comparison macros

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 6e6f8b2: 8342988: GHA: Build JTReg in single step
  • 0d8d8e6: 8336942: Improve test coverage for class loading elements with annotations of different retentions
  • f117cb0: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a0d0f21f0844d402191f5285a154294a2b18059a 8314752: Use google test string comparison macros Jan 8, 2025
@openjdk
Copy link

openjdk bot commented Jan 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 9, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jan 10, 2025

Thanks for the reviews!

@GoeLin
Copy link
Member Author

GoeLin commented Jan 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

Going to push as commit 2d0c61f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 6e6f8b2: 8342988: GHA: Build JTReg in single step
  • 0d8d8e6: 8336942: Improve test coverage for class loading elements with annotations of different retentions
  • f117cb0: 8345684: OperatingSystemMXBean.getSystemCpuLoad() throws NPE

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2025
@openjdk openjdk bot closed this Jan 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@GoeLin Pushed as commit 2d0c61f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8314752 branch January 10, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants