8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index

[shipilev]

Nearly clean backport to fix a Loom bug. The uncleanliness is due to foreign_globals.cpp context change in ForeignGlobals::java_calling_convention, which renamed the argument. I reapplied that hunk by hand.

Additional testing:

• macos-aarch64-server-fastdebug, jdk_loom hotspot_loom
• linux-aarch64-server-fastdebug, tier{1,2,3,4}
• linux-x86_64-server-fastdebug, tier{1,2,3,4}

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8323595 needs maintainer approval
• JDK-8320275 needs maintainer approval

Issues

• JDK-8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index (Bug - P3 - Approved)
• JDK-8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 0f2c2278

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/131/head:pull/131
$ git checkout pull/131

Update a local copy of the PR:
$ git checkout pull/131
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 131

View PR using the GUI difftool:
$ git pr show -t 131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/131.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full - Incremental (35ddcb66)
• 02: Full (f468bfff)
• 01: Full - Incremental (3ae148cc)
• 00: Full (0f2c2278)

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Nearly clean backport to fix a Loom bug. The uncleanliness is due to foreign_globals.cpp context change in ForeignGlobals::java_calling_convention, which renamed the argument. I reapplied that hunk by hand. Tests pass. The patch is a bit risky, because it touches calling conventions.

[openjdk]

@shipilev
8320275: The approval request has been created successfully.

[shipilev]

/issue add JDK-8323595

[openjdk]

@shipilev
Adding additional issue to issue list: 8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs.

[openjdk]

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[shipilev]

/approval 8320275 request (Resubmitting for 21.0.4) Nearly clean backport to fix a Loom bug. The uncleanliness is due to foreign_globals.cpp context change in ForeignGlobals::java_calling_convention, which renamed the argument. I reapplied that hunk by hand. Tests pass. The patch is a bit risky, because it touches calling conventions. There was no product bugtail after >6 weeks in mainline, including JDK 22 EA testing.

/approval 8323595 request Follow-up for JDK-8320275, fixes the incorrect assert.

[openjdk]

@shipilev
8320275: The approval request has been updated successfully.

[openjdk]

@shipilev
8323595: The approval request has been created successfully.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
8323595: is_aligned(p, alignof(OopT))) assertion fails in Jetty without compressed OOPs

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Re-tested all on Linux aarch64, still fully passes.

/integrate

[openjdk]

Going to push as commit 677556d.
Since your change was applied there have been 3 commits pushed to the master branch:

• 8ac4313: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• dc8759c: 8316053: Open some swing tests 3
• ef13a82: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 677556d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.