-
Notifications
You must be signed in to change notification settings - Fork 151
8343599: Kmem limit and max values swapped when printing container information #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into |
|
@RadekCap This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
Webrevs
|
|
/approval request Kmem limit and max values swapped when printing container information |
|
I see no Github Actions testing, can you please enable it? Thx |
|
|
/integrate |
|
/sponsor |
|
Going to push as commit ab69b0d.
Your commit was automatically rebased without conflicts. |
|
@phohensee @RadekCap Pushed as commit ab69b0d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8343599 Kmem limit and max values swapped when printing container information
Clean backport.
Passed tier1 tests.
The only failing tier1 test is java/foreign/nested/TestNested.java which is failing due to preview API on the current master as well with:
(use --enable-preview to enable preview APIs) ... is a preview API and is disabled by default.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1341/head:pull/1341$ git checkout pull/1341Update a local copy of the PR:
$ git checkout pull/1341$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1341/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1341View PR using the GUI difftool:
$ git pr show -t 1341Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1341.diff
Using Webrev
Link to Webrev Comment