Skip to content

8343599: Kmem limit and max values swapped when printing container information #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

RadekCap
Copy link
Contributor

@RadekCap RadekCap commented Jan 18, 2025

Backport of JDK-8343599 Kmem limit and max values swapped when printing container information

Clean backport.
Passed tier1 tests.

The only failing tier1 test is java/foreign/nested/TestNested.java which is failing due to preview API on the current master as well with:

(use --enable-preview to enable preview APIs) ... is a preview API and is disabled by default.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343599 needs maintainer approval

Issue

  • JDK-8343599: Kmem limit and max values swapped when printing container information (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1341/head:pull/1341
$ git checkout pull/1341

Update a local copy of the PR:
$ git checkout pull/1341
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1341/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1341

View PR using the GUI difftool:
$ git pr show -t 1341

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1341.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2025

👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 18, 2025

@RadekCap This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343599: Kmem limit and max values swapped when printing container information

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 5c87961: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04
  • c6c9fdd: 8341982: Simplify JButton/bug4323121.java
  • d6b7816: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible
  • 4a8fbb3: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos
  • 920f02b: 8341412: Various test failures after JDK-8334305
  • 99a9299: 8311546: Certificate name constraints improperly validated with leading period
  • 5b377a3: 8334305: Remove all code for nsk.share.Log verbose mode
  • abd8902: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
  • fe321bb: 8320676: Manual printer tests have no Pass/Fail buttons, instructions close set 1
  • ded4113: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/97119a918bfd52ae5431bb6058d271b24abe93c3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 6cdebf0e4ce274fcaaff0bad292d467e31d698d8 8343599: Kmem limit and max values swapped when printing container information Jan 18, 2025
@openjdk
Copy link

openjdk bot commented Jan 18, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 18, 2025

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 18, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2025

Webrevs

@RadekCap
Copy link
Contributor Author

/approval request Kmem limit and max values swapped when printing container information

@openjdk
Copy link

openjdk bot commented Jan 18, 2025

@RadekCap
8343599: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 18, 2025
@RealCLanger
Copy link
Contributor

I see no Github Actions testing, can you please enable it? Thx

@openjdk
Copy link

openjdk bot commented Jan 20, 2025

⚠️ @RadekCap the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8343599
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 20, 2025
@RadekCap
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@RadekCap
Your change (at version 3342ca3) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

Going to push as commit ab69b0d.
Since your change was applied there have been 12 commits pushed to the master branch:

  • c0ab8a9: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
  • 5c87961: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04
  • c6c9fdd: 8341982: Simplify JButton/bug4323121.java
  • d6b7816: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible
  • 4a8fbb3: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos
  • 920f02b: 8341412: Various test failures after JDK-8334305
  • 99a9299: 8311546: Certificate name constraints improperly validated with leading period
  • 5b377a3: 8334305: Remove all code for nsk.share.Log verbose mode
  • abd8902: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
  • fe321bb: 8320676: Manual printer tests have no Pass/Fail buttons, instructions close set 1
  • ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/97119a918bfd52ae5431bb6058d271b24abe93c3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2025
@openjdk openjdk bot closed this Jan 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@phohensee @RadekCap Pushed as commit ab69b0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants