Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level #1352

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 22, 2025

UX improvement for Epsilon. The patch is simple and was in mainline for a few weeks.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8347256 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1352/head:pull/1352
$ git checkout pull/1352

Update a local copy of the PR:
$ git checkout pull/1352
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1352

View PR using the GUI difftool:
$ git pr show -t 1352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1352.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 22, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 28f9e2d: 8331977: Crash: SIGSEGV in dlerror()
  • 4479c03: 8345375: Improve debuggability of test/jdk/java/net/Socket/CloseAvailable.java
  • 80d9cb3: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html
  • 5603a90: 8341111: open source several AWT tests including menu shortcut tests
  • e2b4f92: 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
  • 3fa03fd: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
  • 42220f3: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1a0fe49732187db9e8776f80feefab4373114f75 8347256: Epsilon: Demote heap size and AlwaysPreTouch warnings to info level Jan 22, 2025
@openjdk
Copy link

openjdk bot commented Jan 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 22, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 22, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2025

Webrevs

@shipilev
Copy link
Member Author

/approval request UX improvement for Epsilon. The patch is simple and was in mainline for a few weeks. Applies cleanly, tests pass. Risk is low: only reshuffles the logging messages.

@openjdk
Copy link

openjdk bot commented Jan 22, 2025

@shipilev
8347256: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 22, 2025
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

Going to push as commit 6d11231.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 8c3ab36: 8345750: Shenandoah: Test TestJcmdHeapDump.java#aggressive intermittent assert(gc_cause() == GCCause::_no_gc) failed: Over-writing cause
  • 28f9e2d: 8331977: Crash: SIGSEGV in dlerror()
  • 4479c03: 8345375: Improve debuggability of test/jdk/java/net/Socket/CloseAvailable.java
  • 80d9cb3: 8343118: [TESTBUG] java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java fails with rror. Can't find HTML file PrintCheckboxManualTest.html
  • 5603a90: 8341111: open source several AWT tests including menu shortcut tests
  • e2b4f92: 8341037: Use standard layouts in DefaultFrameIconTest.java and MenuCrash.java
  • 3fa03fd: 8329320: Simplify awt/print/PageFormat/NullPaper.java test
  • 42220f3: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2025
@openjdk openjdk bot closed this Jan 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@shipilev Pushed as commit 6d11231.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant