Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects #138

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 8, 2024

Clean backport to fix Generational ZGC.

Picking this up for 21u, @fisk -- tell me if that is not a good idea.

Additional testing:

  • Linux x86-64 server fastdebug, hotspot_gc with -XX:+UseZGC -XX:+ZGenerational

Progress

  • Change must not contain extraneous whitespace
  • JDK-8321619 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects (Bug - P1 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/138/head:pull/138
$ git checkout pull/138

Update a local copy of the PR:
$ git checkout pull/138
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 138

View PR using the GUI difftool:
$ git pr show -t 138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/138.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport be49dabd0d7e1cd270399849e5353bf33361c4c5 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2024

Webrevs

Copy link

@fisk fisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for picking it up!

@shipilev
Copy link
Member Author

shipilev commented Jan 8, 2024

/approval request Clean backport to fix Generational ZGC. Applies cleanly. Light testing passes.

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@shipilev
8321619: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects

Reviewed-by: eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 772ac17: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests
  • c21a12d: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • d44b5dc: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • e652bb7: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 1a9c7ec: 8318082: ConcurrentModificationException from IndexWriter
  • b745bb5: 8319883: Zero: Use atomic built-ins for 64-bit accesses
  • a85f3f8: 8320145: Compiler should accept final variable in Record Pattern
  • 1e66488: 8321599: Data loss in AVX3 Base64 decoding
  • d4797b7: 8316693: Simplify at-requires checkDockerSupport()
  • dfc9324: 8319879: Stress mode to randomize incremental inlining decision
  • ... and 15 more: https://git.openjdk.org/jdk21u-dev/compare/966071a5f10a7a8910b2639e10c961924a07d675...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 9, 2024
@shipilev
Copy link
Member Author

shipilev commented Jan 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit 36c2120.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 772ac17: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests
  • c21a12d: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • d44b5dc: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • e652bb7: 8310844: [AArch64] C1 compilation fails because monitor offset in OSR buffer is too large for immediate
  • 1a9c7ec: 8318082: ConcurrentModificationException from IndexWriter
  • b745bb5: 8319883: Zero: Use atomic built-ins for 64-bit accesses
  • a85f3f8: 8320145: Compiler should accept final variable in Record Pattern
  • 1e66488: 8321599: Data loss in AVX3 Base64 decoding
  • d4797b7: 8316693: Simplify at-requires checkDockerSupport()
  • dfc9324: 8319879: Stress mode to randomize incremental inlining decision
  • ... and 15 more: https://git.openjdk.org/jdk21u-dev/compare/966071a5f10a7a8910b2639e10c961924a07d675...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@shipilev Pushed as commit 36c2120.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8321619-genz-youngobjs branch February 7, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants