Skip to content

8348323: Corrupted timezone string in JVM crash log #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dhanalla
Copy link
Contributor

@dhanalla dhanalla commented Feb 3, 2025

Add a error check to "wcstombs" otherwise the "buf" prints junk or corrupted string.

Test performed:

"jcmd < jvm pid > VM.info" for different JVM versions


Progress

  • Change must not contain extraneous whitespace
  • JDK-8348323 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8348323: Corrupted timezone string in JVM crash log (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1382/head:pull/1382
$ git checkout pull/1382

Update a local copy of the PR:
$ git checkout pull/1382
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1382

View PR using the GUI difftool:
$ git pr show -t 1382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1382.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2025

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@dhanalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348323: Corrupted timezone string in JVM crash log

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

  • ef23a01: 8279016: JFR Leak Profiler is broken with Shenandoah
  • c046d85: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp
  • 91457e6: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor
  • ae47d99: 8346082: Output JVMTI agent information in hserr files
  • b942b5e: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats
  • 4159e88: 8350650: Bump update version for OpenJDK: jdk-21.0.8
  • 5806906: 8317808: HTTP/2 stream cancelImpl may leave subscriber registered
  • 951453e: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS
  • 2f9840c: 8339356: Test javax/net/ssl/SSLSocket/Tls13PacketSize.java failed with java.net.SocketException: An established connection was aborted by the software in your host machine
  • 68ad843: 8342635: javax/swing/JFileChooser/FileSystemView/WindowsDefaultIconSizeTest.java creates tmp file in src dir
  • ... and 49 more: https://git.openjdk.org/jdk21u-dev/compare/e1967d5124309de5276ab88d1bcf4d24f2620dab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 2bef5b4a877f4d3bc766558b8782b7b57dee79a8 8348323: Corrupted timezone string in JVM crash log Feb 3, 2025
@openjdk
Copy link

openjdk bot commented Feb 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

⚠️ @dhanalla This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 3, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval ready Pull request is ready to be integrated labels Feb 25, 2025
@dhanalla
Copy link
Contributor Author

dhanalla commented Mar 3, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 3, 2025
@openjdk
Copy link

openjdk bot commented Mar 3, 2025

@dhanalla
Your change (at version 730f313) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 6, 2025

Going to push as commit d29111a.
Since your change was applied there have been 63 commits pushed to the master branch:

  • ef282b7: 8180450: secondary_super_cache does not scale well
  • e48995f: 8336499: Failure when creating non-CRT RSA private keys in SunPKCS11
  • 9d9bcd2: 8314840: 3 gc/epsilon tests ignore external vm options
  • 601e6f9: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails
  • ef23a01: 8279016: JFR Leak Profiler is broken with Shenandoah
  • c046d85: 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp
  • 91457e6: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor
  • ae47d99: 8346082: Output JVMTI agent information in hserr files
  • b942b5e: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats
  • 4159e88: 8350650: Bump update version for OpenJDK: jdk-21.0.8
  • ... and 53 more: https://git.openjdk.org/jdk21u-dev/compare/e1967d5124309de5276ab88d1bcf4d24f2620dab...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 6, 2025
@openjdk openjdk bot closed this Mar 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 6, 2025
@openjdk
Copy link

openjdk bot commented Mar 6, 2025

@phohensee @dhanalla Pushed as commit d29111a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants