Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 11, 2025

Hi all,

This pull request contains a backport of commit 1d392492 from the openjdk/jdk repository.

The commit being backported was authored by Jaikiran Pai on 12 Sep 2024 and was reviewed by Alexey Ivanov, Anthony Scarpino, Phil Race and David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339834 needs maintainer approval

Issue

  • JDK-8339834: Replace usages of -mx and -ms in some tests (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1392/head:pull/1392
$ git checkout pull/1392

Update a local copy of the PR:
$ git checkout pull/1392
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1392

View PR using the GUI difftool:
$ git pr show -t 1392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1392.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 11, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339834: Replace usages of -mx and -ms in some tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1d392492311daceeae12769cb9494eae63289853 8339834: Replace usages of -mx and -ms in some tests Feb 11, 2025
@openjdk
Copy link

openjdk bot commented Feb 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 11, 2025
@openjdk
Copy link

openjdk bot commented Feb 11, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 11, 2025
@sendaoYan
Copy link
Member Author

/approval request Clean backport to replaces the usages of -mx and -ms to -Xmx and -Xms in tests and in one code comment. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Feb 11, 2025

@sendaoYan
8339834: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 11, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2025

Webrevs

@sendaoYan
Copy link
Member Author

This backport PR will make backport JDK-8347302 cleanly.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 11, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 13, 2025

Going to push as commit 4e19a9b.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 4f4c3ce: 8347038: [JMH] jdk.incubator.vector.SpiltReplicate fails NoClassDefFoundError
  • eb82472: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
  • 37ad4db: 8346713: [testsuite] NeverActAsServerClassMachine breaks TestPLABAdaptToMinTLABSize.java TestPinnedHumongousFragmentation.java TestPinnedObjectContents.java
  • 3e55649: 8345368: java/io/File/createTempFile/SpecialTempFile.java fails on Windows Server 2025
  • e122829: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 13, 2025
@openjdk openjdk bot closed this Feb 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 13, 2025
@openjdk
Copy link

openjdk bot commented Feb 13, 2025

@sendaoYan Pushed as commit 4e19a9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant