-
Notifications
You must be signed in to change notification settings - Fork 148
8339834: Replace usages of -mx and -ms in some tests #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8339834: Replace usages of -mx and -ms in some tests #1392
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Clean backport to replaces the usages of -mx and -ms to -Xmx and -Xms in tests and in one code comment. Test-fix only, no risk. |
|
@sendaoYan |
|
This backport PR will make backport JDK-8347302 cleanly. |
|
Thanks for the approved. /integrate |
|
Going to push as commit 4e19a9b.
Your commit was automatically rebased without conflicts. |
|
@sendaoYan Pushed as commit 4e19a9b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit 1d392492 from the openjdk/jdk repository.
The commit being backported was authored by Jaikiran Pai on 12 Sep 2024 and was reviewed by Alexey Ivanov, Anthony Scarpino, Phil Race and David Holmes.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1392/head:pull/1392$ git checkout pull/1392Update a local copy of the PR:
$ git checkout pull/1392$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1392/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1392View PR using the GUI difftool:
$ git pr show -t 1392Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1392.diff
Using Webrev
Link to Webrev Comment