8344925: translet-name ignored when package-name is also set

[galderz]

This is a backport of JDK-8344925: translet-name ignored when package-name is also set

Original patch does not apply cleanly to 21u-dev, because of javadoc and license header year discrepancies.

Testing: tier1 and tier2 passed. Tier 2 includes the PropertiesTest test included in the original PR and individually verified that it passes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8344925 needs maintainer approval

Issue

• JDK-8344925: translet-name ignored when package-name is also set (Bug - P4 - Approved)

Reviewers

• Joe Wang (@JoeWang-Java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1412/head:pull/1412
$ git checkout pull/1412

Update a local copy of the PR:
$ git checkout pull/1412
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1412/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1412

View PR using the GUI difftool:
$ git pr show -t 1412

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1412.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@galderz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344925: translet-name ignored when package-name is also set

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 330 new commits pushed to the master branch:

• 38a356d: 8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful
• 13eedbe: 8333117: Remove support of remote and manual debuggee launchers
• 3bc5b96: 8267174: Many test files have the wrong Copyright header
• ... and 327 more: https://git.openjdk.org/jdk21u-dev/compare/b7d92cd0ae781de6c51ea965c16bd6e0c396e9f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JoeWang-Java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (738fa789)

[bridgekeeper]

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[galderz]

@JoeWang-Java Can you review this?

[bridgekeeper]

@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[galderz]

Keep it open

[JoeWang-Java]

Looks good. Thanks.

[openjdk]

⚠️ @galderz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[galderz]

/approval request The bug impacts Red Hat middleware engineers trying to adopt JDK's xalan API

[openjdk]

@galderz
8344925: The approval request has been created successfully.

[Karm]

@galderz

Platform	JDK archive	test/jaxp/javax/xml Results	Test Status
Linux amd64	Download	View	🟢
Linux aarch64	Download	View	🟢
MacOS aarch64	Download	View	🟢
Windows amd64	Download	View	🟢

[GoeLin]

Hi @galderz
Could you pleas give some more information in your fix request? See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
Also, could you please merge head to get an up-to-date test run?

[GoeLin]

I successfully ran this through SAPs testing.

[galderz]

/approval request The bug impacts Red Hat middleware engineers trying to adopt JDK's xalan API. Without this fix, it is not possible to fix the generated class name rather than being random. This is necessary so that Java code that relies on JDK's xalan API can run fine when compiled as a GraalVM native image, which requires class names that are loaded via reflection to be configured in advance.

[openjdk]

@galderz
8344925: The approval request has been updated successfully.

[galderz]

I've updated to the latest master

[galderz]

/integrate

[openjdk]

@galderz
Your change (at version 738fa78) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit eb8320c.
Since your change was applied there have been 330 commits pushed to the master branch:

• 38a356d: 8316629: j.text.DateFormatSymbols setZoneStrings() exception is unhelpful
• 13eedbe: 8333117: Remove support of remote and manual debuggee launchers
• 3bc5b96: 8267174: Many test files have the wrong Copyright header
• ... and 327 more: https://git.openjdk.org/jdk21u-dev/compare/b7d92cd0ae781de6c51ea965c16bd6e0c396e9f7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @galderz Pushed as commit eb8320c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.