8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class

[vieiro]

Backport of JDK-8339728 from 24u that solves some accessibility issues on Windows, for parity with 11.0.27-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk.

The new accessibility test passes on Windows 10 (tested with JAWS v. 2025.2412.102 - February 2025 )

---

Progress

• JDK-8339728 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1414/head:pull/1414
$ git checkout pull/1414

Update a local copy of the PR:
$ git checkout pull/1414
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1414/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1414

View PR using the GUI difftool:
$ git pr show -t 1414

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1414.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vieiro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 1b49a33: 8342098: Write a test to compare the images
• 2ff0232: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java
• fdf6dbe: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (55bcca72)

[vieiro]

/approval request Please approve this backport to JDK-17 that fixes a bug in the accessibility classes. It allows voice-reading the whole shortcuts in JMenuItems (these were previously truncated in Windows). Tested with AWS accessibility on Windows 10.

[openjdk]

@vieiro
8339728: The approval request has been created successfully.

[GoeLin]

Hi @vieiro
Thanks for adressing this!
Did this really read out the menu items in your test?
Did you double-check the test is failing without the fix?
It did not work out in my setup on the first try, but I did not find time to look
into this further. I assumed it is related to my local JAWS setup.

[vieiro]

Hi @vieiro Thanks for adressing this!
Did this really read out the menu items in your test?

Yes. Peculiarly JAWS was reading the text of JMenuItems in perfect english, and some of the shortcut words in spanish (for instance, Shift was read out as Mayúsculas). Windows language was set to "english" (but the keyboard was set to spanish, I may change the keyboard layout if you want and double check).

Did you double-check the test is failing without the fix?

Yes. The shortcut "Ctrl+Shift+Period" was read out as "Control plus Mayúsculas plus P" (and not Period).

It did not work out in my setup on the first try, but I did not find time to look into this further. I assumed it is related to my local JAWS setup.

Could be. As I said JAWS seems to be speaking out some shortcut words in spanish and others in english.

[vieiro]

@GoeLin D'oh. I hit the "Close and comment" button instead of the "Comment" button. Reopening.

[GoeLin]

Hi @vieiro, thanks for the heads up! approved.
Will you also do 17? That would be great!

[vieiro]

Hi @vieiro, thanks for the heads up! approved. Will you also do 17? That would be great!

Hi @GoeLin . Yep, 17 and 11.

[vieiro]

/approval request Please approve this backport to JDK-21 that fixes an accessibility problem in Windows, where JMenuItem shortcuts were not properly read out. Low risk. Verified in Windows 10 with JAWS.

[openjdk]

@vieiro
8339728: The approval request has been updated successfully.

[vieiro]

Hi @GoeLin I'm afraid there's a typo at JDK-8339728 : label jddk21u-fix-yes should read jdk21u-fix-yes, I'm afraid (note a double d). Would you please fix that one for me? Thanks!

[GoeLin]

Sorry for that, fixed!

[vieiro]

/integrate

[openjdk]

@vieiro
Your change (at version 55bcca7) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit af639f3.
Since your change was applied there have been 3 commits pushed to the master branch:

• 1b49a33: 8342098: Write a test to compare the images
• 2ff0232: 8283664: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintTextTest.java
• fdf6dbe: 8328730: Convert java/awt/print/bug8023392/bug8023392.html applet test to main

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @vieiro Pushed as commit af639f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.