Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322512: StringBuffer.repeat does not work correctly after toString() was called #143

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 8, 2024

Clean backport to fix JDK 21 feature misbehavior.

Additional testing:

  • New regression test fails without the fix, passes with it
  • GHA (includes some Repeat tests)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322512 needs maintainer approval

Issue

  • JDK-8322512: StringBuffer.repeat does not work correctly after toString() was called (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/143/head:pull/143
$ git checkout pull/143

Update a local copy of the PR:
$ git checkout pull/143
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 143

View PR using the GUI difftool:
$ git pr show -t 143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/143.diff

Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

shipilev commented Jan 8, 2024

/approval request Clean backport to fix JDK 21 feature misbehavior. Applies cleanly. Tests work.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport df22fb322e6c4c9931a770bd0abf4c43b83c4e4a 8322512: StringBuffer.repeat does not work correctly after toString() was called Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@shipilev
8322512: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Jan 8, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@JimLaskey Unknown command close - for a list of valid commands use /help.

@GoeLin
Copy link
Member

GoeLin commented Jan 9, 2024

@JimLaskey, why did you want to close this issue?

@JimLaskey
Copy link
Member

JimLaskey commented Jan 9, 2024

It was a mistake. I was trying to close my own pr because Alexsey took it over and I was in the wrong window.

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322512: StringBuffer.repeat does not work correctly after toString() was called

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • e08eb0e: 8321582: yield .class not parsed correctly.
  • d92ff7c: 8320309: AIX: pthreads created by foreign test library don't work as expected
  • cd16670: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal
  • 2abfc99: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
  • 1ea0d08: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed
  • 2bf21b4: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • 4537bfa: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • a28d29c: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • a1d7bcf: 6928542: Chinese characters in RTF are not decoded
  • d5b8c28: 8322725: (tz) Update Timezone Data to 2023d
  • ... and 27 more: https://git.openjdk.org/jdk21u-dev/compare/966071a5f10a7a8910b2639e10c961924a07d675...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 15, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

Going to push as commit 6ee8f47.
Since your change was applied there have been 37 commits pushed to the master branch:

  • e08eb0e: 8321582: yield .class not parsed correctly.
  • d92ff7c: 8320309: AIX: pthreads created by foreign test library don't work as expected
  • cd16670: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal
  • 2abfc99: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
  • 1ea0d08: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed
  • 2bf21b4: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • 4537bfa: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • a28d29c: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • a1d7bcf: 6928542: Chinese characters in RTF are not decoded
  • d5b8c28: 8322725: (tz) Update Timezone Data to 2023d
  • ... and 27 more: https://git.openjdk.org/jdk21u-dev/compare/966071a5f10a7a8910b2639e10c961924a07d675...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 15, 2024
@openjdk openjdk bot closed this Jan 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@shipilev Pushed as commit 6ee8f47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8322512-stringbuffer-repeat branch February 7, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants