Skip to content

8337506: Disable "best-fit" mapping on Windows command line #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented Feb 27, 2025

I'd like to backport this for parity with 21.0.8-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337506 needs maintainer approval
  • Change requires CSR request JDK-8349538 to be approved

Issues

  • JDK-8337506: Disable "best-fit" mapping on Windows command line (Bug - P4)
  • JDK-8349538: Disable "best-fit" mapping on Windows command line (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1438/head:pull/1438
$ git checkout pull/1438

Update a local copy of the PR:
$ git checkout pull/1438
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1438

View PR using the GUI difftool:
$ git pr show -t 1438

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1438.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2025

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ff634a967027cfa56b666d31c45db9a4acc09ea4 8337506: Disable "best-fit" mapping on Windows command line Feb 27, 2025
@openjdk
Copy link

openjdk bot commented Feb 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Feb 27, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 27, 2025

Webrevs

Copy link
Contributor

@martinuy martinuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this backport, @kvergizova . Looks good (clean) to me. Looks like the CSR has not been approved (yet) for 21u. We should get an approval before moving forward with this change.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

@kvergizova This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants