Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323086: Shenandoah: Heap could be corrupted by oom during evacuation #145

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jan 8, 2024


Progress

  • JDK-8323086 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323086: Shenandoah: Heap could be corrupted by oom during evacuation (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/145/head:pull/145
$ git checkout pull/145

Update a local copy of the PR:
$ git checkout pull/145
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/145/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 145

View PR using the GUI difftool:
$ git pr show -t 145

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/145.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c4a83bd6f6c45e72bd776e929005be0aa9408867 8323086: Shenandoah: Heap could be corrupted by oom during evacuation Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Jan 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323086: Shenandoah: Heap could be corrupted by oom during evacuation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • f57f2cb: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
  • 551855c: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
  • 4b82978: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • 45df078: 8319124: Update XML Security for Java to 3.0.3
  • 77c743e: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
  • b114a5e: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support
  • 7fe7cfc: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
  • 1b5aeb9: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
  • 6ee8f47: 8322512: StringBuffer.repeat does not work correctly after toString() was called
  • e08eb0e: 8321582: yield .class not parsed correctly.
  • ... and 16 more: https://git.openjdk.org/jdk21u-dev/compare/b745bb515f19d47e5246773ddfc48a23deda1345...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 15, 2024
@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 16, 2024
@openjdk
Copy link

openjdk bot commented Jan 16, 2024

@earthling-amzn
Your change (at version 0911e46) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

Going to push as commit 9ca8761.
Since your change was applied there have been 72 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2024
@openjdk openjdk bot closed this Jan 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@shipilev @earthling-amzn Pushed as commit 9ca8761.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants