Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...] #146

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 9, 2024

Clean backport to fix a corner case in javac.

Additional testing:

  • macos-aarch64-server-fastdebug, new regression test fails without the patch, passes with it
  • macos-aarch64-server-fastdebug, langtools_all pass

Progress

  • JDK-8321164 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...] (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/146/head:pull/146
$ git checkout pull/146

Update a local copy of the PR:
$ git checkout pull/146
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 146

View PR using the GUI difftool:
$ git pr show -t 146

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/146.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03c4595173d564df97aa4f2b3156adcd4be379fa 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...] Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jan 9, 2024

/approval request Clean backport to fix a corner case in javac, hit by users. Applies cleanly. Tests work.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@shipilev
8321164: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 2bf21b4: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • 4537bfa: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • a28d29c: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • a1d7bcf: 6928542: Chinese characters in RTF are not decoded
  • d5b8c28: 8322725: (tz) Update Timezone Data to 2023d
  • 9406448: 8316132: CDSProtectionDomain::get_shared_protection_domain should check for exception
  • 36c2120: 8321619: Generational ZGC: ZColorStoreGoodOopClosure is only valid for young objects
  • 772ac17: 8210410: Refactor java.util.Currency:i18n shell tests to plain java tests
  • c21a12d: 8296631: NSS tests failing on OL9 linux-aarch64 hosts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 10, 2024
@shipilev
Copy link
Member Author

Checking here: @lahodaj, you are good with this going into 21u?

@lahodaj
Copy link

lahodaj commented Jan 15, 2024

No problem from me.

@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2024

Going to push as commit f57f2cb.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 551855c: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
  • 4b82978: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • 45df078: 8319124: Update XML Security for Java to 3.0.3
  • 77c743e: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
  • b114a5e: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support
  • 7fe7cfc: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
  • 1b5aeb9: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
  • 6ee8f47: 8322512: StringBuffer.repeat does not work correctly after toString() was called
  • e08eb0e: 8321582: yield .class not parsed correctly.
  • d92ff7c: 8320309: AIX: pthreads created by foreign test library don't work as expected
  • ... and 12 more: https://git.openjdk.org/jdk21u-dev/compare/d44b5dc7a634b08f27f9a3e71112607a12023f8b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2024
@openjdk openjdk bot closed this Jan 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2024
@openjdk
Copy link

openjdk bot commented Jan 16, 2024

@shipilev Pushed as commit f57f2cb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8321164-javac-classreader-typeanno branch February 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants