Skip to content

8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024#1465

Closed
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-959e0265-master
Closed

8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024#1465
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-959e0265-master

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 11, 2025

Hi all,

This pull request contains a backport of commit 768b0241 from the openjdk/jdk repository.

The commit being backported was authored by Vladimir Ivanov on 3 Mar 2025 and was reviewed by Xiaohong Gong, Derek White and Sandhya Viswanathan.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8350682 needs maintainer approval

Issue

  • JDK-8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1465/head:pull/1465
$ git checkout pull/1465

Update a local copy of the PR:
$ git checkout pull/1465
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1465/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1465

View PR using the GUI difftool:
$ git pr show -t 1465

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1465.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 959e0265cfd829a1f857835e1ee95c75b6f6c9cb 8350682: [JMH] vector.IndexInRangeBenchmark failed with IndexOutOfBoundsException for size=1024 Mar 11, 2025
@openjdk
Copy link

openjdk bot commented Mar 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 11, 2025
@openjdk
Copy link

openjdk bot commented Mar 11, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval Clean backport to fix the JMH test bug, and make related JMH tests run normally. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@sendaoYan usage: /approval [<id>] (request|cancel) [<text>]

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the JMH test bug, and make related JMH tests run normally. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@sendaoYan
8350682: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 18, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

Going to push as commit a5678d3.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 6bee54c: 8335662: [AArch64] C1: guarantee(val < (1ULL << nbits)) failed: Field too big for insn
  • 47aafc2: 8350412: [21u] AArch64: Ambiguous frame layout leads to incorrect traces in JFR
  • d8291f5: 8316580: HttpClient with StructuredTaskScope does not close when a task fails
  • 544b111: 8338064: Give better error for ConcurrentHashTable corruption
  • 8faa7b6: 8350211: CTW: Attempt to preload all classes in constant pool
  • 6c1e127: 8338202: Shenandoah: Improve handshake closure labels
  • 7a25ef2: 8340784: Remove PassFailJFrame constructor with screenshots
  • 7dd8c8c: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
  • 5b0f3a6: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
  • 4dbb0c9: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
  • ... and 35 more: https://git.openjdk.org/jdk21u-dev/compare/6957d6fa2d795922f65f8c2451be90e1e99cef50...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2025
@openjdk openjdk bot closed this Mar 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 20, 2025
@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@sendaoYan Pushed as commit a5678d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant