Skip to content

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 11, 2025

Hi all,

This pull request contains a backport of commit 5c552a9d from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 6 Mar 2025 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349358 needs maintainer approval

Issue

  • JDK-8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1466/head:pull/1466
$ git checkout pull/1466

Update a local copy of the PR:
$ git checkout pull/1466
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1466

View PR using the GUI difftool:
$ git pr show -t 1466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1466.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c14b3c228f4ed2361ace77172410a1769ff93c9b 8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope Mar 11, 2025
@openjdk
Copy link

openjdk bot commented Mar 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2025

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to remove obsolescent JMH tests which can not run normally, no risk.

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@sendaoYan
8349358: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 17, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

Going to push as commit b3cd888.
Since your change was applied there have been 65 commits pushed to the master branch:

  • 32ac3e7: 8342075: HttpClient: improve HTTP/2 flow control checks
  • 8ed020e: 8350786: Some java/lang jtreg tests miss requires vm.hasJFR
  • f3112ef: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing
  • 3d6562b: 8348110: Update LCMS to 2.17
  • a3b2421: 8280991: [XWayland] No displayChanged event after setDisplayMode call
  • c7bcdb6: 8345598: Upgrade NSS binaries for interop tests
  • 0c08a0c: 8350260: Improve HTML instruction formatting in PassFailJFrame
  • dfbe834: 8294155: Exception thrown before awaitAndCheck hangs PassFailJFrame
  • 17973ad: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
  • e985f85: 8343529: serviceability/sa/ClhsdbWhere.java fails AssertionFailure: Corrupted constant pool
  • ... and 55 more: https://git.openjdk.org/jdk21u-dev/compare/6957d6fa2d795922f65f8c2451be90e1e99cef50...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2025
@openjdk openjdk bot closed this Mar 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2025
@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@sendaoYan Pushed as commit b3cd888.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant