Skip to content

8303770: Remove Baltimore root certificate expiring in May 2025 #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Mar 12, 2025

Backport of a required removal of an expired certificate. 21.0.8-oracle parity.


Progress

  • JDK-8303770 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303770: Remove Baltimore root certificate expiring in May 2025 (Task - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1480/head:pull/1480
$ git checkout pull/1480

Update a local copy of the PR:
$ git checkout pull/1480
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1480

View PR using the GUI difftool:
$ git pr show -t 1480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1480.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2025

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303770: Remove Baltimore root certificate expiring in May 2025

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c401a6e: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
  • 78d9827: 8326586: Improve Speed of System.map
  • 95ac895: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2371696781edc040d8fa8133c78b284a2e3de1ed 8303770: Remove Baltimore root certificate expiring in May 2025 Mar 12, 2025
@openjdk
Copy link

openjdk bot commented Mar 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

⚠️ @jerboaa This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 12, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2025

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 13, 2025

Testing:

  • GHA
  • test/jdk/sun/security/lib/cacerts/VerifyCACerts.java has the warning WARNING: cert "baltimorecybertrustca [jdk]" expiry "Tue May 13 01:59:00 CEST 2025" will expire within 90 days prior this patch and is gone after.
  • test/jdk/sun/security/ssl tests. All pass.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 13, 2025
@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

Going to push as commit f16c950.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c401a6e: 8327169: serviceability/dcmd/vm/SystemMapTest.java and SystemDumpMapTest.java may fail after JDK-8326586
  • 78d9827: 8326586: Improve Speed of System.map
  • 95ac895: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2025
@openjdk openjdk bot closed this Mar 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 13, 2025
@openjdk
Copy link

openjdk bot commented Mar 13, 2025

@jerboaa Pushed as commit f16c950.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@gnu-andrew
Copy link
Member

Should this not have gone into 21u for release in April, if the certificate expires in May?

@GoeLin
Copy link
Member

GoeLin commented Mar 13, 2025

Hmm, can we remove them while they are still valid?
Also, we usually follow what Oracle does.
But if Oracle would want to get this to the April release, we see it first for July, and after building it there they backport it further to April, which we might see next week. But this would pop up in the filters and I will not miss this.

@jerboaa
Copy link
Contributor Author

jerboaa commented Mar 13, 2025

Going by previous precedent like JDK-8273150, JDK-8225083 and JDK-8274215 we should not remove the expired certificate before it's actually expired. So July seems correct to me, but we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants