Skip to content

8340713: Open source DnD tests - Set5#1487

Closed
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8340713
Closed

8340713: Open source DnD tests - Set5#1487
GoeLin wants to merge 2 commits intoopenjdk:masterfrom
GoeLin:goetz_backport_8340713

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 13, 2025

I backport this for parity with 21.0.8-oracle

Resolved ProblemList, probably clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340713 needs maintainer approval

Issue

  • JDK-8340713: Open source DnD tests - Set5 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1487/head:pull/1487
$ git checkout pull/1487

Update a local copy of the PR:
$ git checkout pull/1487
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1487/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1487

View PR using the GUI difftool:
$ git pr show -t 1487

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1487.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 13, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340713: Open source DnD tests - Set5

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fc7244da96a9423146c4a46bcc3bbfc205900c3b 8340713: Open source DnD tests - Set5 Mar 13, 2025
@openjdk
Copy link

openjdk bot commented Mar 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 13, 2025
@openjdk
Copy link

openjdk bot commented Mar 13, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 14, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 14, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2025

Going to push as commit 80dce19.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2025
@openjdk openjdk bot closed this Mar 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2025
@openjdk
Copy link

openjdk bot commented Mar 14, 2025

@GoeLin Pushed as commit 80dce19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8340713 branch April 10, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant