8338202: Shenandoah: Improve handshake closure labels

[satyenme]

Backporting JDK-8338202: Shenandoah: Improve handshake closure labels. Change makes handshake labels more descriptive, to streamline debugging Shenandoah GC. Ran GHA Sanity Checks, and local Tier 1, and Tier 2 tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8338202 needs maintainer approval

Issue

• JDK-8338202: Shenandoah: Improve handshake closure labels (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1495/head:pull/1495
$ git checkout pull/1495

Update a local copy of the PR:
$ git checkout pull/1495
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1495

View PR using the GUI difftool:
$ git pr show -t 1495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1495.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338202: Shenandoah: Improve handshake closure labels

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

• 7a25ef2: 8340784: Remove PassFailJFrame constructor with screenshots
• 7dd8c8c: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
• 5b0f3a6: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• 4dbb0c9: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
• 4881735: 8334644: Automate javax/print/attribute/PageRangesException.java
• e654a53: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing
• a498e0e: 8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
• 27e24e0: 8340985: Open source some Desktop related tests
• 84ddbcc: 8340164: Open source few Component tests - Set1
• 333dd41: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)
• ... and 46 more: https://git.openjdk.org/jdk21u-dev/compare/e48995f4997e08e50a0ed1781e1972dd5c303297...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (faef125b)

[satyenme]

/approval request for backport. This change makes Shenandoah's handshake name labels more descriptive.

Reasoning: This change will streamline debugging Shenandoah errors by providing more explicit logging.

Risk: Low. Tip change was merged in August of 2024 without any issues. From an implementation standpoint, this change essentially just adds a string parameter and passes the value in place of the literal "ShenandoahRendezvous".

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally

[openjdk]

@satyenme
8338202: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version faef125) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 6c1e127.
Since your change was applied there have been 56 commits pushed to the master branch:

• 7a25ef2: 8340784: Remove PassFailJFrame constructor with screenshots
• 7dd8c8c: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
• 5b0f3a6: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
• 4dbb0c9: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
• 4881735: 8334644: Automate javax/print/attribute/PageRangesException.java
• e654a53: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing
• a498e0e: 8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
• 27e24e0: 8340985: Open source some Desktop related tests
• 84ddbcc: 8340164: Open source few Component tests - Set1
• 333dd41: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)
• ... and 46 more: https://git.openjdk.org/jdk21u-dev/compare/e48995f4997e08e50a0ed1781e1972dd5c303297...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @satyenme Pushed as commit 6c1e127.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.