Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE #150

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 9, 2024

Clean backport to improve platform support. Unblocks future backports that rely on default cache line size.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321269 needs maintainer approval

Issue

  • JDK-8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/150/head:pull/150
$ git checkout pull/150

Update a local copy of the PR:
$ git checkout pull/150
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 150

View PR using the GUI difftool:
$ git pr show -t 150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/150.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a56286f7ad9a8110026f48eb45f1d7a273b2f9fb 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to improve platform support. Unblocks future backports that rely on default cache line size.

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@shipilev
8321269: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

  • ad2e114: 8323243: JNI invocation of an abstract instance method corrupts the stack
  • d69a097: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468
  • 8084244: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 2697a9d: 8318696: Do not use LFS64 symbols on Linux
  • 1f9b03e: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
  • be8733b: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils
  • fae1a03: 8312416: Tests in Locale should have more descriptive names
  • ada400c: 8318158: RISC-V: implement roundD/roundF intrinsics
  • 1dd2f2a: 8169475: WheelModifier.java fails by timeout
  • e9be531: 8077371: Binary files in JAXP test should be removed
  • ... and 93 more: https://git.openjdk.org/jdk21u-dev/compare/d44b5dc7a634b08f27f9a3e71112607a12023f8b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 24, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 24, 2024

Going to push as commit 34d97ab.
Since your change was applied there have been 104 commits pushed to the master branch:

  • 63e52ed: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1
  • ad2e114: 8323243: JNI invocation of an abstract instance method corrupts the stack
  • d69a097: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468
  • 8084244: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • 2697a9d: 8318696: Do not use LFS64 symbols on Linux
  • 1f9b03e: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
  • be8733b: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils
  • fae1a03: 8312416: Tests in Locale should have more descriptive names
  • ada400c: 8318158: RISC-V: implement roundD/roundF intrinsics
  • 1dd2f2a: 8169475: WheelModifier.java fails by timeout
  • ... and 94 more: https://git.openjdk.org/jdk21u-dev/compare/d44b5dc7a634b08f27f9a3e71112607a12023f8b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2024
@openjdk openjdk bot closed this Jan 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@shipilev Pushed as commit 34d97ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant