Skip to content

8340784: Remove PassFailJFrame constructor with screenshots #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 17, 2025

I backport this for parity with 21.0.8-oracle.


Progress

  • JDK-8340784 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340784: Remove PassFailJFrame constructor with screenshots (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1508/head:pull/1508
$ git checkout pull/1508

Update a local copy of the PR:
$ git checkout pull/1508
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1508

View PR using the GUI difftool:
$ git pr show -t 1508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1508.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340784: Remove PassFailJFrame constructor with screenshots

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 712699f: 8309978: [x64] Fix useless padding
  • be4ee93: 8338010: WB_IsFrameDeoptimized miss ResourceMark

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 50ca450417a5da7d4c6c08154515b8407bf656e8 8340784: Remove PassFailJFrame constructor with screenshots Mar 17, 2025
@openjdk
Copy link

openjdk bot commented Mar 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 17, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 17, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 17, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 18, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Mar 18, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

Going to push as commit 7a25ef2.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 7dd8c8c: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
  • 5b0f3a6: 8347286: (fs) Remove some extensions from java/nio/file/Files/probeContentType/Basic.java
  • 4dbb0c9: 8346581: JRadioButton/ButtonGroupFocusTest.java fails in CI on Linux
  • 4881735: 8334644: Automate javax/print/attribute/PageRangesException.java
  • e654a53: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing
  • a498e0e: 8341637: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
  • 27e24e0: 8340985: Open source some Desktop related tests
  • 84ddbcc: 8340164: Open source few Component tests - Set1
  • 333dd41: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)
  • 712699f: 8309978: [x64] Fix useless padding
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/5ff88f61f6ab04ddf3936f8b249f9a48974f53d1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2025
@openjdk openjdk bot closed this Mar 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2025
@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@GoeLin Pushed as commit 7a25ef2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant