Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination #151

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 9, 2024

Clean backport to eliminate a trivial inefficiency in release builds.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8323065 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/151/head:pull/151
$ git checkout pull/151

Update a local copy of the PR:
$ git checkout pull/151
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 151

View PR using the GUI difftool:
$ git pr show -t 151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/151.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @shipilev could not find any commit with hash eb9e754b3a439cc3ce36c2c9393bc8b250343844. Please update the title with the hash for an existing commit.

@shipilev
Copy link
Member Author

shipilev commented Jan 9, 2024

⚠️ @shipilev could not find any commit with hash eb9e754b3a439cc3ce36c2c9393bc8b250343844. Please update the title with the hash for an existing commit.

Bot is mistaken, here it is: openjdk/jdk@eb9e754

@openjdk openjdk bot changed the title Backport eb9e754b3a439cc3ce36c2c9393bc8b250343844 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2024

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Jan 9, 2024

/approval request Clean backport to eliminate a trivial inefficiency in release builds. Applies cleanly.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@shipilev
8323065: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • e08eb0e: 8321582: yield .class not parsed correctly.
  • d92ff7c: 8320309: AIX: pthreads created by foreign test library don't work as expected
  • cd16670: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal
  • 2abfc99: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
  • 1ea0d08: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed
  • 2bf21b4: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • 4537bfa: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • a28d29c: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • a1d7bcf: 6928542: Chinese characters in RTF are not decoded
  • d5b8c28: 8322725: (tz) Update Timezone Data to 2023d
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/d44b5dc7a634b08f27f9a3e71112607a12023f8b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 15, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

Going to push as commit 1b5aeb9.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 6ee8f47: 8322512: StringBuffer.repeat does not work correctly after toString() was called
  • e08eb0e: 8321582: yield .class not parsed correctly.
  • d92ff7c: 8320309: AIX: pthreads created by foreign test library don't work as expected
  • cd16670: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal
  • 2abfc99: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
  • 1ea0d08: 8311992: Test java/lang/Thread/virtual/JfrEvents::testVirtualThreadPinned failed
  • 2bf21b4: 8322783: prioritize /etc/os-release over /etc/SuSE-release in hs_err/info output
  • 4537bfa: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • a28d29c: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • a1d7bcf: 6928542: Chinese characters in RTF are not decoded
  • ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/d44b5dc7a634b08f27f9a3e71112607a12023f8b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 15, 2024
@openjdk openjdk bot closed this Jan 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

@shipilev Pushed as commit 1b5aeb9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant