Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318154: Improve stability of WheelModifier.java test #153

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Jan 9, 2024

Hi all,

This pull request contains a backport of commit 668d4b07 from the openjdk/jdk repository.

The commit being backported was authored by Renjith Kannath Pariyangad on 16 Oct 2023 and was reviewed by Alexey Ivanov.

Thanks!


Progress

  • JDK-8318154 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318154: Improve stability of WheelModifier.java test (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/153/head:pull/153
$ git checkout pull/153

Update a local copy of the PR:
$ git checkout pull/153
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/153/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 153

View PR using the GUI difftool:
$ git pr show -t 153

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/153.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 668d4b077f260a30a90842a01b38a9cf6718d418 8318154: Improve stability of WheelModifier.java test Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review January 11, 2024 15:23
@openjdk
Copy link

openjdk bot commented Jan 11, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 11, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318154: Improve stability of WheelModifier.java test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 0ac1bb7: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
  • 9b5cd9d: 8315594: Open source few headless Swing misc tests
  • f57f2cb: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
  • 551855c: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
  • 4b82978: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • 45df078: 8319124: Update XML Security for Java to 3.0.3
  • 77c743e: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
  • b114a5e: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support
  • 7fe7cfc: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
  • 1b5aeb9: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
  • ... and 13 more: https://git.openjdk.org/jdk21u-dev/compare/772ac17887b11abf8d1769b4abd44346d01aa0ec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 17, 2024
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@SoniaZaldana
Your change (at version 2f03de8) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

Going to push as commit 8d536b6.
Since your change was applied there have been 69 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2024
@openjdk openjdk bot closed this Jan 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@shipilev @SoniaZaldana Pushed as commit 8d536b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants