-
Notifications
You must be signed in to change notification settings - Fork 147
8338136: Hotspot should support multiple large page sizes on Windows #1547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338136: Hotspot should support multiple large page sizes on Windows #1547
Conversation
|
👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into |
|
@dhanalla This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 39 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/integrate |
|
/sponsor |
|
Going to push as commit 7ef1881.
Your commit was automatically rebased without conflicts. |
|
@phohensee @dhanalla Pushed as commit 7ef1881. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This pull request introduces enhancements to the handling of large page sizes in the OpenJDK for Windows systems, aiming to align its capabilities with those observed on Linux platforms. Investigation through SPECJBB benchmarks across various platforms revealed a 16-year-old limitation in handling large pages over 4MB for IA32/AMD64 architectures, with no such constraints for Windows on ARM64.
JBS issue https://bugs.openjdk.org/browse/JDK-8338136
The goal of this change is to overcome the 4MB large page size limitation, thereby enhancing Windows' large page support to match Linux's more flexible handling capabilities. This decision to remove 4MB constraint was influenced by insights from Linux's implementation strategies. The implementation supports multiple large page sizes , specifically excluding the IA32 architecture.
Key changes and bug fixes include enabling Windows support for multiple huge page sizes with -XX:LargePageSizeInBytes, and utilizing logic from JDK-8271195 to use the largest available large page size smaller than LargePageSizeInBytes when available.
This update removes the 4MB limit on AMD64 for Windows, populating the shared array to enable fallback options on all architectures except IA32. The implementation introduces an experimental flag, defaulting to FALSE, to facilitate testing and gradual adoption of these changes. The flag allows users to opt-in to the new large page handling logic, with a warning mechanism implemented for cases where the requested large page size is not a multiple of the OS minimum page size.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1547/head:pull/1547$ git checkout pull/1547Update a local copy of the PR:
$ git checkout pull/1547$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1547/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1547View PR using the GUI difftool:
$ git pr show -t 1547Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1547.diff
Using Webrev
Link to Webrev Comment