Skip to content

Conversation

@dhanalla
Copy link

@dhanalla dhanalla commented Mar 25, 2025

This pull request introduces enhancements to the handling of large page sizes in the OpenJDK for Windows systems, aiming to align its capabilities with those observed on Linux platforms. Investigation through SPECJBB benchmarks across various platforms revealed a 16-year-old limitation in handling large pages over 4MB for IA32/AMD64 architectures, with no such constraints for Windows on ARM64.

JBS issue https://bugs.openjdk.org/browse/JDK-8338136

The goal of this change is to overcome the 4MB large page size limitation, thereby enhancing Windows' large page support to match Linux's more flexible handling capabilities. This decision to remove 4MB constraint was influenced by insights from Linux's implementation strategies. The implementation supports multiple large page sizes , specifically excluding the IA32 architecture.

Key changes and bug fixes include enabling Windows support for multiple huge page sizes with -XX:LargePageSizeInBytes, and utilizing logic from JDK-8271195 to use the largest available large page size smaller than LargePageSizeInBytes when available.

This update removes the 4MB limit on AMD64 for Windows, populating the shared array to enable fallback options on all architectures except IA32. The implementation introduces an experimental flag, defaulting to FALSE, to facilitate testing and gradual adoption of these changes. The flag allows users to opt-in to the new large page handling logic, with a warning mechanism implemented for cases where the requested large page size is not a multiple of the OS minimum page size.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8343896 to be approved
  • JDK-8338136 needs maintainer approval

Issues

  • JDK-8338136: Hotspot should support multiple large page sizes on Windows (Enhancement - P3 - Approved)
  • JDK-8343896: Hotspot should support multiple large page sizes on Windows (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1547/head:pull/1547
$ git checkout pull/1547

Update a local copy of the PR:
$ git checkout pull/1547
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1547

View PR using the GUI difftool:
$ git pr show -t 1547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1547.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back dhanalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@dhanalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338136: Hotspot should support multiple large page sizes on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4ded28380b6756e0679d80706f76bd6e78c370b9 8338136: Hotspot should support multiple large page sizes on Windows Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

⚠️ @dhanalla This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 25, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 3, 2025
@dhanalla
Copy link
Author

dhanalla commented Apr 3, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 3, 2025
@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@dhanalla
Your change (at version 964e0a4) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 11, 2025

Going to push as commit 7ef1881.
Since your change was applied there have been 95 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 11, 2025
@openjdk openjdk bot closed this Apr 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 11, 2025
@openjdk
Copy link

openjdk bot commented Apr 11, 2025

@phohensee @dhanalla Pushed as commit 7ef1881.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants